Android: fixes timeout for WaitForLogMatch.

Android: fixes timeout for WaitForLogMatch.

The parameter would only be used if StartMonitoringLogcat hasn't been called.
This leads to wrong timeouts and mismatches when waiting for log lines.

BUG=171347
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177977

[bulach, 2013-01-22 00:56:57]

ptal

[aberent, 2013-01-22 01:37:00]

lgtm

[Sami, 2013-01-22 01:37:25]

Change itself lgtm, just a documentation/cleanup nit.

https://codereview.chromium.org/12035016/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12035016/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:781: timeout: How long WaitForLogMatch
will wait for the given match
It seems like we could get rid of the timeout argument to this function
completely. In any case this comment should be updated.

[bulach, 2013-01-22 01:55:57]

thanks both! fixed the comments, CQing..

https://codereview.chromium.org/12035016/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12035016/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:781: timeout: How long WaitForLogMatch
will wait for the given match
On 2013/01/22 01:37:25, Sami wrote:
> It seems like we could get rid of the timeout argument to this function
> completely. In any case this comment should be updated.

as discussed, deprecating this parameter and created crbug.com/171347 to clean
this up.

[commit-bot: I haz the power, 2013-01-22 01:56:25]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Peter Beverloo, 2013-01-22 02:03:48]

lgtm

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
build/android/pylib/android_commands.py:781: timeout: deprecated, don't use
(timeout for adb to start).
nit: s/deprecated/Deprecated/. Parameter explanations here all start with a
capital. I also don't think we need the previous explanation, and that something
like "Deprecated and unused. Will be removed soon." would be clearer.

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
build/android/pylib/android_commands.py:826: timeout: timeout in seconds to wait
for a log match.
nit: dito on the capital.

[bulach, 2013-01-22 02:07:36]

thanks peter! nits addressed, CQing.

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
build/android/pylib/android_commands.py:781: timeout: deprecated, don't use
(timeout for adb to start).
On 2013/01/22 02:03:48, Peter Beverloo wrote:
> nit: s/deprecated/Deprecated/. Parameter explanations here all start with a
> capital. I also don't think we need the previous explanation, and that
something
> like "Deprecated and unused. Will be removed soon." would be clearer.

Done.

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
build/android/pylib/android_commands.py:826: timeout: timeout in seconds to wait
for a log match.
On 2013/01/22 02:03:48, Peter Beverloo wrote:
> nit: dito on the capital.

Done.

[Peter Beverloo, 2013-01-22 02:07:41]

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12035016/diff/5001/build/android/pylib/androi...
build/android/pylib/android_commands.py:781: timeout: deprecated, don't use
(timeout for adb to start).
On 2013/01/22 02:03:48, Peter Beverloo wrote:
> like "Deprecated and unused. Will be removed soon."

I see that it is used in the pexpect.spawn() call. Let's keep it as it is,
except for the capital?

[commit-bot: I haz the power, 2013-01-22 02:07:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/12035016/6002

[commit-bot: I haz the power, 2013-01-22 04:01:48]

Change committed as 177977