Source/platform/heap/Heap.h - Issue 1203493004: [tracing] Adding class-wise memory statistics to blink gc memory dumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Heap.h

Issue 1203493004: [tracing] Adding class-wise memory statistics to blink gc memory dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove useless check. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/Heap.h

diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h

index 850384f573acbdfb8edf30a293dde64a63ec0100..fd8da32387b87e85ca04f5ca93267a7104388095 100644

--- a/Source/platform/heap/Heap.h

+++ b/Source/platform/heap/Heap.h

@@ -388,7 +388,7 @@ public:

virtual void checkAndMarkPointer(Visitor*, Address) = 0;

virtual void markOrphaned();

- virtual void takeSnapshot(String dumpBaseName, size_t pageIndex, size_t* outFreeSize, size_t* outFreeCount) = 0;

+ virtual void takeSnapshot(String dumpBaseName, size_t pageIndex, ThreadState::GCSnapshotInfo&, size_t* outFreeSize, size_t* outFreeCount) = 0;

#if ENABLE(GC_PROFILING)

virtual const GCInfo* findGCInfo(Address) = 0;

virtual void snapshot(TracedValue*, ThreadState::SnapshotInfo*) = 0;

@@ -470,7 +470,7 @@ public:

void checkAndMarkPointer(Visitor*, Address) override;

void markOrphaned() override;

- void takeSnapshot(String dumpBaseName, size_t pageIndex, size_t* outFreeSize, size_t* outFreeCount) override;

+ void takeSnapshot(String dumpBaseName, size_t pageIndex, ThreadState::GCSnapshotInfo&, size_t* outFreeSize, size_t* outFreeCount) override;

#if ENABLE(GC_PROFILING)

const GCInfo* findGCInfo(Address) override;

void snapshot(TracedValue*, ThreadState::SnapshotInfo*) override;

@@ -535,7 +535,7 @@ public:

void checkAndMarkPointer(Visitor*, Address) override;

void markOrphaned() override;

- void takeSnapshot(String dumpBaseName, size_t pageIndex, size_t* outFreeSize, size_t* outFreeCount) override;

+ void takeSnapshot(String dumpBaseName, size_t pageIndex, ThreadState::GCSnapshotInfo&, size_t* outFreeSize, size_t* outFreeCount) override;

#if ENABLE(GC_PROFILING)

const GCInfo* findGCInfo(Address) override;

void snapshot(TracedValue*, ThreadState::SnapshotInfo*) override;

@@ -681,7 +681,7 @@ public:

virtual ~BaseHeap();

void cleanupPages();

- void takeSnapshot(const String& dumpBaseName);

+ void takeSnapshot(const String& dumpBaseName, ThreadState::GCSnapshotInfo&);

#if ENABLE(ASSERT) || ENABLE(GC_PROFILING)

BasePage* findPageFromAddress(Address);

#endif

« no previous file with comments | « Source/platform/heap/GCInfo.h ('k') | Source/platform/heap/Heap.cpp » ('j') | no next file with comments »