Include destination port for websocket throttling.

Include destination port for websocket throttling.

Before this change, a pending connection to 127.0.0.1:80 would block a
connection to 127.0.0.1:81 from starting. With this change, they are considered
to be distinct for throttling purposes.

Added a unit test to verify that pending connections to distinct ports do not
block each other.

Took the opportunity to simplify WebSocketThrottle a bit, using the IPEndPoint
as the map key directly instead of creating a string to be the key.

Modified the WebSocketJobSpdy[23]Tests to use port 80 both for the blocking
connection and the connection being throttled. Previously the blocking
connection used port 0, which meant that this change caused the throttling tests
to fail.

TEST=net_unittests, chrome

BUG=172202
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181448

[Adam Rice, 2013-01-24 04:48:11]

Please take a look.

[Takashi Toyoshima, 2013-01-24 09:51:00]

lgtm with nits

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
File net/websockets/websocket_throttle.cc (right):

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
net/websockets/websocket_throttle.cc:6: 
#include <algorithm>

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
File net/websockets/websocket_throttle.h (right):

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
net/websockets/websocket_throttle.h:53: // elsewhere, so we use map<> for
portability.
As far as I know, comments on something removed is not recommended.
I think it's better to comment at codereview site before requesting review.

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
net/websockets/websocket_throttle.h:57: ~WebSocketThrottle();
Right.
Also this class missed DISALLOW_COPY_AND_ASSIGN, too :(

[Adam Rice, 2013-01-25 04:07:36]

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
File net/websockets/websocket_throttle.cc (right):

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
net/websockets/websocket_throttle.cc:6: 
On 2013/01/24 09:51:00, Takashi Toyoshima (chromium) wrote:
> #include <algorithm>

Good catch. Done.

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
File net/websockets/websocket_throttle.h (right):

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
net/websockets/websocket_throttle.h:53: // elsewhere, so we use map<> for
portability.
On 2013/01/24 09:51:00, Takashi Toyoshima (chromium) wrote:
> As far as I know, comments on something removed is not recommended.
> I think it's better to comment at codereview site before requesting review.

Yes. I removed the comment.

https://codereview.chromium.org/12033072/diff/1/net/websockets/websocket_thro...
net/websockets/websocket_throttle.h:57: ~WebSocketThrottle();
On 2013/01/24 09:51:00, Takashi Toyoshima (chromium) wrote:
> Right.
> Also this class missed DISALLOW_COPY_AND_ASSIGN, too :(

I didn't notice that! Fixed.

[Takashi Toyoshima, 2013-01-25 05:36:54]

LGTM.

[commit-bot: I haz the power, 2013-02-08 05:34:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/12033072/8

[commit-bot: I haz the power, 2013-02-08 07:38:08]

Change committed as 181448