Make PPAPI test servers start in parallel

Make PPAPI test servers start in parallel

BUG=162094
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178718

[dmichael (off chromium), 2013-01-23 22:47:44]

yzshen for chrome/test/ppapi
phajdan.jr for net/test

[Paweł Hajdan Jr., 2013-01-24 01:39:35]

https://codereview.chromium.org/12033057/diff/2002/net/test/local_test_server.h
File net/test/local_test_server.h (right):

https://codereview.chromium.org/12033057/diff/2002/net/test/local_test_server...
net/test/local_test_server.h:42: bool StartInBackground() WARN_UNUSED_RESULT;
Please add comments, including for Start method.

[yzshen1, 2013-01-24 17:42:02]

.*ppapi.* LGTM
Thanks!

https://codereview.chromium.org/12033057/diff/9001/chrome/test/ppapi/ppapi_te...
File chrome/test/ppapi/ppapi_test.h (right):

https://codereview.chromium.org/12033057/diff/9001/chrome/test/ppapi/ppapi_te...
chrome/test/ppapi/ppapi_test.h:86: // start before runnint the test. This is for
cases where we need an
runnint -> running

[dmichael (off chromium), 2013-01-24 18:59:40]

yzshen: I had to shuffle things around to make sure the WS or SSL server is
started before we request its port.

phajdan.jr: I had to add NOTIMPLEMENTED versions of the new functions for
RemoteTestServer. The PPAPI tests aren't run for Clank/Bling, so it just needs
to be able to compile. I didn't want to go implement these without being able to
actually exercise them.

PTAL

https://codereview.chromium.org/12033057/diff/2002/net/test/local_test_server.h
File net/test/local_test_server.h (right):

https://codereview.chromium.org/12033057/diff/2002/net/test/local_test_server...
net/test/local_test_server.h:42: bool StartInBackground() WARN_UNUSED_RESULT;
On 2013/01/24 01:39:35, Paweł Hajdan Jr. wrote:
> Please add comments, including for Start method.
Ah, I should have done that automatically. Thanks, done.

[Paweł Hajdan Jr., 2013-01-24 19:31:57]

LGTM

https://codereview.chromium.org/12033057/diff/6014/net/test/local_test_server.h
File net/test/local_test_server.h (right):

https://codereview.chromium.org/12033057/diff/6014/net/test/local_test_server...
net/test/local_test_server.h:41: // false on failure.
nit: "false on failure" is redundant, please remove.

https://codereview.chromium.org/12033057/diff/6014/net/test/local_test_server...
net/test/local_test_server.h:57: // Returns true on success, false on failure.
nit: "false on failure" is redundant, please remove.

https://codereview.chromium.org/12033057/diff/6014/net/test/local_test_server...
net/test/local_test_server.h:60: // Block until ths test server is ready.
Returns true on success, false on
nit: "false on failure" is redundant, please remove.

[commit-bot: I haz the power, 2013-01-24 21:52:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/12033057/21

[yzshen1, 2013-01-24 22:00:47]

.*ppapi.* still LGTM

https://codereview.chromium.org/12033057/diff/21/chrome/test/ppapi/ppapi_test.h
File chrome/test/ppapi/ppapi_test.h (right):

https://codereview.chromium.org/12033057/diff/21/chrome/test/ppapi/ppapi_test...
chrome/test/ppapi/ppapi_test.h:83: // Get the URL of the the given |test_case|
for the given HTTP test server.
nit: Get -> Gets

[commit-bot: I haz the power, 2013-01-24 22:46:35]

Failed to trigger a try job on mac_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-01-24 22:48:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/12033057/2019

[commit-bot: I haz the power, 2013-01-25 01:23:08]

Change committed as 178718