Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: samples/process.cc

Issue 12033011: Add Isolate parameter to Persistent class. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added new kind of callback Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/process.cc
diff --git a/samples/process.cc b/samples/process.cc
index ae6a5500cd1bb506dde593725189a3b0269315fa..d8d95129b07b8830d47a197dbafaff0434d5a86f 100644
--- a/samples/process.cc
+++ b/samples/process.cc
@@ -273,8 +273,9 @@ JsHttpRequestProcessor::~JsHttpRequestProcessor() {
// Dispose the persistent handles. When noone else has any
// references to the objects stored in the handles they will be
// automatically reclaimed.
- context_.Dispose();
- process_.Dispose();
+ v8::Isolate* isolate = context_->GetIsolate();
+ context_.Dispose(isolate);
+ process_.Dispose(isolate);
}

Powered by Google App Engine
This is Rietveld 408576698