Hide addresses in traced code.

src/string-stream.cc

Index: src/string-stream.cc
diff --git a/src/string-stream.cc b/src/string-stream.cc
index fc07d94ded237ee4ca79ebde48fe036680de6910..57386fef5abea2da1877ea4bacf965a4e41cc3b0 100644
--- a/src/string-stream.cc
+++ b/src/string-stream.cc
@@ -167,10 +167,14 @@ void StringStream::Add(Vector<const char> format, Vector<FmtElm> elms) {
       break;
     }
     case 'p': {
-      void* value = current.data_.u_pointer_;
-      EmbeddedVector<char, 20> formatted;
-      OS::SNPrintF(formatted, temp.start(), value);
-      Add(formatted.start());
+      if (FLAG_trace_code_addresses) {
+        void* value = current.data_.u_pointer_;

[Sven Panne, 2013/01/21 09:51:05]

I would prefer just a ternary ?: to calculate value (e.g. NULL when we don't
want to see the actual pointer) instead of the whole if/else.

[Massi, 2013/01/21 15:27:49]

The code would be more "linear" but the output would display "NULL pointers"
instead of "hidden values".
I would prefer to have the explicit "0xXXXXXXXX" string in the log so that
nobody will ever mistake it for a NULL.

+        EmbeddedVector<char, 20> formatted;
+        OS::SNPrintF(formatted, temp.start(), value);
+        Add(formatted.start());
+      } else {
+        Add("0xXXXXXXXX");
+      }
       break;
     }
     default:
@@ -206,7 +210,11 @@ void StringStream::PrintObject(Object* o) {
       Add("#%d#", debug_object_cache->length());
       debug_object_cache->Add(HeapObject::cast(o));
     } else {
-      Add("@%p", o);
+      if (FLAG_trace_code_addresses) {

[Sven Panne, 2013/01/21 09:51:05]

Do we really need this if we have the change above? It looks like this is
handled there already in an identical way.

[Massi, 2013/01/21 15:27:49]

Done.

+        Add("@%p", o);
+      } else {
+        Add("0xXXXXXXXX");
+      }
     }
   }
 }