Issue 12030002: Partially revert "Don't include web apps with empty names into autocomplete search."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12030002: Partially revert "Don't include web apps with empty names into autocomplete search." (Closed)

Created:
7 years, 11 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 11 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Partially revert "Don't include web apps with empty names into autocomplete search." This reverts commit http://src.chromium.org/viewvc/chrome?view=rev&revision=154070. Changing manifest was unnecessary to fix Omnibox issue. But change introduced unexpected issue with cloud print dialog hosted under www.google.com/cloudprint/ If dialog needs to "Sign in" and app's urls list includes dialog url, then "Sign in" is opened in new windows instead of current one. It completely breaks cloud print flow. BUG=170301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178168

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/resources/cloud_print_app/manifest.json	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12030002/1

7 years, 11 months ago (2013-01-22 20:07:05 UTC) #3

Message was sent while issue was closed.

Change committed as 178168