Recognize "\r\n" line endings in base::JSONParser to report correct line numbers in errors

base/json/json_parser_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_parser.h"
 
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 201 matching lines @@
   // Test line and column counting
   const char* big_json = "[\n0,\n1,\n2,\n3,4,5,6 7,\n8,\n9\n]";
   // error here ---------------------------------^
   root.reset(JSONReader::ReadAndReturnError(big_json, JSON_PARSE_RFC,
                                             &error_code, &error_message));
   EXPECT_FALSE(root.get());
   EXPECT_EQ(JSONParser::FormatErrorMessage(5, 10, JSONReader::kSyntaxError),
             error_message);
   EXPECT_EQ(JSONReader::JSON_SYNTAX_ERROR, error_code);
 
+  // Test line and column counting with "\r\n" line ending
+  const char* big_json_crlf =

[Mark Mentovai, 2013/02/04 17:41:00]

This and line 212 should both be “const char xxx[]” and not “const char* xxx”.

+    "[\r\n0,\r\n1,\r\n2,\r\n3,4,5,6 7,\r\n8,\r\n9\r\n]";

[Mark Mentovai, 2013/02/04 17:41:00]

This file uses four (not two) spaces of extra indentation for continuation lines
of this form, as on line 307.

+  // error here --------------------^
+  root.reset(JSONReader::ReadAndReturnError(big_json_crlf, JSON_PARSE_RFC,
+                                            &error_code, &error_message));

[Mark Mentovai, 2013/02/04 17:41:00]

You haven’t cleared error_message or error_code from their last use, so this
test isn’t really fully testing everything that you intend.

+  EXPECT_FALSE(root.get());
+  EXPECT_EQ(JSONParser::FormatErrorMessage(5, 10, JSONReader::kSyntaxError),
+            error_message);
+  EXPECT_EQ(JSONReader::JSON_SYNTAX_ERROR, error_code);
+
   // Test each of the error conditions
   root.reset(JSONReader::ReadAndReturnError("{},{}", JSON_PARSE_RFC,
                                             &error_code, &error_message));
   EXPECT_FALSE(root.get());
   EXPECT_EQ(JSONParser::FormatErrorMessage(1, 3,
       JSONReader::kUnexpectedDataAfterRoot), error_message);
   EXPECT_EQ(JSONReader::JSON_UNEXPECTED_DATA_AFTER_ROOT, error_code);
 
   std::string nested_json;
   for (int i = 0; i < 101; ++i) {
@@ skipping 65 matching lines @@
   std::string error_message;
   int error_code = 0;
   scoped_ptr<Value> root(
       JSONReader::ReadAndReturnError(kUtf8Data, JSON_PARSE_RFC, &error_code,
                                      &error_message));
   EXPECT_TRUE(root.get()) << error_message;
 }
 
 }  // namespace internal
 }  // namespace base