Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 12026016: Implement new Task Manager and Edit Bookmark style, etc. (Closed)

Created:
7 years, 11 months ago by msw
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, yoshiki+watch_chromium.org, Mike Wittman
Visibility:
Public.

Description

Implement new Task Manager and Edit Bookmark style, etc. Add a common CreateDialogWidget, use for Task Manager and Edit Bookmark. Use Browser as |context| for Task Manager, and as |parent| for Edit Bookmark. Update layout and appearance for each dialog with --enable-new-dialog-style. (see pics at http://crbug.com/166075#c19 and http://crbug.com/166075#c20) TODO(followup): Avoid Windows native controls or support dialog transparency. BUG=166075 TEST=Task Manager and Edit Bookmark style with --enable-new-dialog-style; no other appearance/behavior changes. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177759

Patch Set 1 : Implement new Task Manager and Edit Bookmark Style, etc. #

Patch Set 2 : Update ShowTaskManager and ShowBackgroundPages OVERRIDEs and calls. #

Total comments: 2

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -109 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_notification_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 7 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/browser_dialogs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 7 chunks +26 lines, -53 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/window/dialog_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 2 2 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, please take a look; thanks! Should these go to chrome-ui-review? (this style currently ...
7 years, 11 months ago (2013-01-18 16:47:37 UTC) #1
sky
LGTM https://codereview.chromium.org/12026016/diff/8001/ui/views/window/dialog_delegate.cc File ui/views/window/dialog_delegate.cc (right): https://codereview.chromium.org/12026016/diff/8001/ui/views/window/dialog_delegate.cc#newcode154 ui/views/window/dialog_delegate.cc:154: DialogDelegateView::DialogDelegateView() { } style guide actually says no ...
7 years, 11 months ago (2013-01-18 17:01:22 UTC) #2
msw
Done. https://codereview.chromium.org/12026016/diff/8001/ui/views/window/dialog_delegate.cc File ui/views/window/dialog_delegate.cc (right): https://codereview.chromium.org/12026016/diff/8001/ui/views/window/dialog_delegate.cc#newcode154 ui/views/window/dialog_delegate.cc:154: DialogDelegateView::DialogDelegateView() { } On 2013/01/18 17:01:22, sky wrote: ...
7 years, 11 months ago (2013-01-18 17:14:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12026016/12
7 years, 11 months ago (2013-01-18 17:15:23 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-18 21:23:57 UTC) #5
Message was sent while issue was closed.
Change committed as 177759

Powered by Google App Engine
This is Rietveld 408576698