Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3203)

Unified Diff: cc/top_controls_manager_unittest.cc

Issue 12025031: Find root scroll layer at tree activation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/layer_tree_impl.cc ('K') | « cc/top_controls_manager_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/top_controls_manager_unittest.cc
diff --git a/cc/top_controls_manager_unittest.cc b/cc/top_controls_manager_unittest.cc
index d081042f99404c05904bbdb2b988023f4de5de5d..79274c97755207a78e29c6ee3e60f71fd95e1194 100644
--- a/cc/top_controls_manager_unittest.cc
+++ b/cc/top_controls_manager_unittest.cc
@@ -27,7 +27,6 @@ class MockTopControlsManagerClient : public TopControlsManagerClient {
update_draw_properties_needed_(false) {
active_tree_ = LayerTreeImpl::create(&host_impl_);
root_scroll_layer_ = LayerImpl::create(active_tree_.get(), 1);
- active_tree_->set_root_scroll_layer(root_scroll_layer_.get());
}
virtual ~MockTopControlsManagerClient() {}
@@ -40,20 +39,25 @@ class MockTopControlsManagerClient : public TopControlsManagerClient {
update_draw_properties_needed_ = true;
}
- virtual LayerTreeImpl* activeTree() OVERRIDE {
- return active_tree_.get();
+ virtual bool haveRootScrollLayer() const OVERRIDE {
+ return true;
}
- TopControlsManager* manager() {
- if (!manager_)
- manager_ = TopControlsManager::Create(this, kTopControlsHeight);
- return manager_.get();
+ virtual float rootScrollLayerTotalScrollY() const OVERRIDE {
+ return root_scroll_layer_->scrollOffset().y() +
+ root_scroll_layer_->scrollDelta().y();
}
LayerImpl* rootScrollLayer() {
return root_scroll_layer_.get();
}
+ TopControlsManager* manager() {
+ if (!manager_)
+ manager_ = TopControlsManager::Create(this, kTopControlsHeight);
+ return manager_.get();
+ }
+
private:
FakeImplProxy proxy_;
FakeLayerTreeHostImpl host_impl_;
« cc/layer_tree_impl.cc ('K') | « cc/top_controls_manager_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698