Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 12025030: Add wrapper class to media for support of VP9 video, and add a command line flag to enable the supp… (Closed)

Created:
7 years, 11 months ago by Tom Finegan
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, jimbankoski, fgalligan1
Visibility:
Public.

Description

Add wrapper class to media for support of VP9 video, and add a command line flag to enable the support. This initial version of the wrapper provides support for decoding VP9 video in WebM container files, and is disabled by default. New flag added: --enable-vp9-playback TBR=brettw,scherkus,xhwang BUG=166094 TEST=VP9 video in WebM containers plays back in <video> elements when --enable-vp9-playback is specified on the command line. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177842

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -38 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/video_decoder_config.h View 2 chunks +6 lines, -2 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 3 chunks +22 lines, -3 lines 0 comments Download
A + media/filters/vpx_video_decoder.h View 4 chunks +24 lines, -33 lines 0 comments Download
A media/filters/vpx_video_decoder.cc View 1 chunk +340 lines, -0 lines 2 comments Download
M media/media.gyp View 3 chunks +16 lines, -0 lines 0 comments Download
M webkit/media/filter_helpers.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Finegan
Re(re(re))landing the VP9 wrapper. Fingers crossed...
7 years, 11 months ago (2013-01-18 21:47:48 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 11 months ago (2013-01-18 21:50:52 UTC) #2
xhwang
lgtm since this is relanding the original patch. Based on offline conversation, the diff since ...
7 years, 11 months ago (2013-01-18 22:05:58 UTC) #3
Tom Finegan
Trying the CQ again. https://codereview.chromium.org/12025030/diff/1/media/filters/vpx_video_decoder.cc File media/filters/vpx_video_decoder.cc (right): https://codereview.chromium.org/12025030/diff/1/media/filters/vpx_video_decoder.cc#newcode249 media/filters/vpx_video_decoder.cc:249: if (buffer->GetDataSize()) { On 2013/01/18 ...
7 years, 11 months ago (2013-01-18 22:15:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tomfinegan@chromium.org/12025030/1
7 years, 11 months ago (2013-01-18 22:15:56 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-19 04:48:17 UTC) #6
Message was sent while issue was closed.
Change committed as 177842

Powered by Google App Engine
This is Rietveld 408576698