Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3900)

Unified Diff: chrome/common/extensions/extension.h

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: extension_service_unittest fixed Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 4c9986b055aba67ff5d6cb8136b4feab06db23aa..a6ead5b410b3df15e24b9f05f21615941f78ea03 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -643,7 +643,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const extensions::Manifest* manifest() const {
return manifest_.get();
}
- const std::string default_locale() const { return default_locale_; }
bool incognito_split_mode() const { return incognito_split_mode_; }
bool offline_enabled() const { return offline_enabled_; }
const OAuth2Info& oauth2_info() const { return oauth2_info_; }
@@ -785,7 +784,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadSandboxedPages(string16* error);
// Must be called after LoadPlugins().
bool LoadRequirements(string16* error);
- bool LoadDefaultLocale(string16* error);
bool LoadOfflineEnabled(string16* error);
bool LoadBackgroundScripts(string16* error);
bool LoadBackgroundScripts(const std::string& key, string16* error);
@@ -906,9 +904,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// The absolute path to the directory the extension is stored in.
FilePath path_;
- // Default locale for fall back. Can be empty if extension is not localized.
- std::string default_locale_;
-
// If true, a separate process will be used for the extension in incognito
// mode.
bool incognito_split_mode_;
« no previous file with comments | « chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698