Issue 12025004: Android make sandbox/linux/seccomp-bpf compile on i386

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12025004: Android make sandbox/linux/seccomp-bpf compile on i386 (Closed)

Created:
7 years, 11 months ago by jln (very slow on Chromium)

Modified:
7 years, 11 months ago

Reviewers:
Markus (顧孟勤)

CC:
chromium-reviews, agl, jln+watch_chromium.org, palmer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Android make sandbox/linux/seccomp-bpf compile on i386 BUG=166704 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177542

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -42 lines)			Patch
M	sandbox/linux/sandbox_linux.gypi	View		3 chunks	+17 lines, -1 line	0 comments	Download
M	sandbox/linux/services/android_arm_ucontext.h	View		2 chunks	+1 line, -8 lines	0 comments	Download
A	sandbox/linux/services/android_i386_ucontext.h	View	1	1 chunk	+79 lines, -0 lines	1 comment	Download
M	sandbox/linux/services/android_ucontext.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	sandbox/linux/services/android_x86_ucontext.h	View		1 chunk	+0 lines, -31 lines	0 comments	Download

Total messages: 4 (0 generated)

jln (very slow on Chromium)

Android's bionic libc, glibc and the Linux kernel all have their own sauce and small ...

7 years, 11 months ago (2013-01-17 23:31:39 UTC) #1

Markus (顧孟勤)

lgtm Not happy that we are losing x86-64 on Android. But you are probably right ...

7 years, 11 months ago (2013-01-18 00:09:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/12025004/3001

7 years, 11 months ago (2013-01-18 00:10:16 UTC) #3

Message was sent while issue was closed.

Change committed as 177542