Fix pylint presubmit check so that it works on Windows.

Fix pylint presubmit check so that it works on Windows.

r176777 introduced a change that relied on os.path.samepath, which does not exist on Windows.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=177701

[chrisha, 2013-01-18 15:50:13]

PTAL.

[M-A Ruel, 2013-01-18 15:57:03]

Use same file if available

[chrisha, 2013-01-18 16:11:15]

On 2013/01/18 15:57:03, Marc-Antoine Ruel wrote:
> Use same file if available

Done.

PTAL.

[M-A Ruel, 2013-01-18 16:31:46]

https://codereview.chromium.org/12021013/diff/4001/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/12021013/diff/4001/presubmit_canned_checks.py...
presubmit_canned_checks.py:646: if hasattr(input_api.os_path, 'samefile'):
Actually, it could be written shorter with:

def samefile(a, b):
  # Default implementation for platforms lacking os.path.samefile like Windows.
  return input_api.os_path.abspath(a) == input_api.os_path.abspath(b)

samefile = getattr(input_api.os_path, 'samefile', samefile)
if samefile(input_api.PresubmitLocalPath(), input_api.change.RepositoryRoot()):
  return regex

[chrisha, 2013-01-18 16:52:11]

PTAL?

https://codereview.chromium.org/12021013/diff/4001/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/12021013/diff/4001/presubmit_canned_checks.py...
presubmit_canned_checks.py:646: if hasattr(input_api.os_path, 'samefile'):
On 2013/01/18 16:31:46, Marc-Antoine Ruel wrote:
> Actually, it could be written shorter with:
> 
> def samefile(a, b):
>   # Default implementation for platforms lacking os.path.samefile like
Windows.
>   return input_api.os_path.abspath(a) == input_api.os_path.abspath(b)
> 
> samefile = getattr(input_api.os_path, 'samefile', samefile)
> if samefile(input_api.PresubmitLocalPath(),
input_api.change.RepositoryRoot()):
>   return regex

And this is where it shows that I'm not really a Python guy ;)

Done.

[M-A Ruel, 2013-01-18 16:58:37]

lgtm, thanks.

[commit-bot: I haz the power, 2013-01-18 17:44:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisha@chromium.org/12021013/1002

[commit-bot: I haz the power, 2013-01-18 17:46:58]

Change committed as 177701

[Isaac (away), 2013-01-18 19:02:05]

lgtm

Lgtm, thanks.