Implemented Asynchronous Initialization of BluetoothAdapter.

We cannot run adapter callbacks inside BluetoothAdapterWin because passing scoped_refptr<BluetoothAdapter>(this) will destroy the adapter itself after the callback is finished.

Instead, bluetooth_adapter_factory.cc maintains a vector of callbacks and they will be run once the adapter is initialized.

I also put Bluetooth API initialization code into bluetooth_init_win.h and bluetooth_init_win.cc. From now on any code that wants to use Windows Bluetooth APIs should just include bluetooth_init_win.h.

BUG=135470
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178311

[youngki, 2013-01-18 21:56:07]

Hi Scott, could you review this CL? This CL should complete the asynchronous
initialization of Bluetooth Adapter; with this CL Bluetooth Adapter will only be
used after it's initialized, at least for Windows.

[keybuk, 2013-01-18 22:58:15]

What is the continuing purpose of BluetoothAdapterFactory::GetAdapter() ? It
doesn't look like this method will work anymore, since it will not initialize
the adapter instance.

[youngki, 2013-01-18 23:06:36]

On 2013/01/18 22:58:15, keybuk wrote:
> What is the continuing purpose of BluetoothAdapterFactory::GetAdapter() ? It
> doesn't look like this method will work anymore, since it will not initialize
> the adapter instance.

BluetoothAdapterFactory::GetAdapter() is needed in
chrome/common/extensions/permissions/bluetooth_device_permission.cc to set the
permission message. We need adapter to get the device info, but we should not
instantiate it if there is no adapter; that's why we made GetAdapter() to return
the adapter if it exists, and NULL if it does not exist.

[keybuk, 2013-01-18 23:13:54]

I don't think this is entirely clear from the method names and comments, in
particular "run callback on adapter ready" really doesn't seem to be the right
method to "create and initialize the adapter, or return the adapter if already
initialized" - I'd probably assume that GetAdapter() was the right method!

[youngki, 2013-01-19 01:25:31]

On 2013/01/18 23:13:54, keybuk wrote:
> I don't think this is entirely clear from the method names and comments, in
> particular "run callback on adapter ready" really doesn't seem to be the right
> method to "create and initialize the adapter, or return the adapter if already
> initialized" - I'd probably assume that GetAdapter() was the right method!

I renamed GetAdapter() to MaybeGetAdapter() and also enhanced the comment for
RunCallbackOnAdapterReady(). Please take a look.

[keybuk, 2013-01-19 01:32:29]

Let's call RunCallbackOnAdapterReady() just GetAdapter() then :-)

[youngki, 2013-01-19 02:29:13]

On 2013/01/19 01:32:29, keybuk wrote:
> Let's call RunCallbackOnAdapterReady() just GetAdapter() then :-)

Done.

[keybuk, 2013-01-22 18:40:57]

lgtm with a few nits below

https://chromiumcodereview.appspot.com/12018024/diff/1019/chrome/common/exten...
File chrome/common/extensions/permissions/bluetooth_device_permission.cc
(right):

https://chromiumcodereview.appspot.com/12018024/diff/1019/chrome/common/exten...
chrome/common/extensions/permissions/bluetooth_device_permission.cc:49: if
(bluetooth_adapter) {
should this be:

 if (bluetooth_adapter.get()) {

?

https://chromiumcodereview.appspot.com/12018024/diff/1019/device/bluetooth/bl...
File device/bluetooth/bluetooth_adapter_factory.h (right):

https://chromiumcodereview.appspot.com/12018024/diff/1019/device/bluetooth/bl...
device/bluetooth/bluetooth_adapter_factory.h:22: AdapterCallback;
newline afer this?

https://chromiumcodereview.appspot.com/12018024/diff/1019/device/bluetooth/bl...
device/bluetooth/bluetooth_adapter_factory.h:30: static void GetAdapter(const
AdapterCallback& callback);
Better comment would be something like:

Returns the shared instance of the default adapter, creating and initializing it
if necessary. |callback| is called with the adpter instance passed only once the
adapter is fully initialized and ready to use.

[youngki, 2013-01-22 20:38:13]

Thanks for the review Scott. I am now assigning this to Mike and Nikita for
ownership approval.

Nikita, could you review the following files for ownership approval?

chrome/browser/chromeos/system/ash_system_tray_delegate.cc
chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc

Mike, could you review the following files for ownership approval?

chrome/browser/extensions/*
chrome/common/extensions/permissions/bluetooth_device_permission.cc

https://chromiumcodereview.appspot.com/12018024/diff/1019/chrome/common/exten...
File chrome/common/extensions/permissions/bluetooth_device_permission.cc
(right):

https://chromiumcodereview.appspot.com/12018024/diff/1019/chrome/common/exten...
chrome/common/extensions/permissions/bluetooth_device_permission.cc:49: if
(bluetooth_adapter) {
On 2013/01/22 18:40:57, keybuk wrote:
> should this be:
> 
>  if (bluetooth_adapter.get()) {
> 
> ?

From the discussion from
https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-d...
I think using the scoped_refptr directly in boolean expression is common.

https://chromiumcodereview.appspot.com/12018024/diff/1019/device/bluetooth/bl...
File device/bluetooth/bluetooth_adapter_factory.h (right):

https://chromiumcodereview.appspot.com/12018024/diff/1019/device/bluetooth/bl...
device/bluetooth/bluetooth_adapter_factory.h:22: AdapterCallback;
On 2013/01/22 18:40:57, keybuk wrote:
> newline afer this?

Done.

https://chromiumcodereview.appspot.com/12018024/diff/1019/device/bluetooth/bl...
device/bluetooth/bluetooth_adapter_factory.h:30: static void GetAdapter(const
AdapterCallback& callback);
On 2013/01/22 18:40:57, keybuk wrote:
> Better comment would be something like:
> 
> Returns the shared instance of the default adapter, creating and initializing
it
> if necessary. |callback| is called with the adpter instance passed only once
the
> adapter is fully initialized and ready to use.

Done.

[miket_OOO, 2013-01-22 22:37:03]

> Mike, could you review the following files for ownership approval?
> 
> chrome/browser/extensions/*
> chrome/common/extensions/permissions/bluetooth_device_permission.cc

OWNERS LGTM

[Nikita (slow), 2013-01-23 09:58:14]

lgtm

[youngki, 2013-01-23 15:05:01]

Thanks for reviewing; putting it on CQ now.

[commit-bot: I haz the power, 2013-01-23 15:05:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/12018024/17001

[commit-bot: I haz the power, 2013-01-23 16:58:03]

Change committed as 178311

[Ami GONE FROM CHROMIUM, 2013-01-23 17:40:58]

https://chromiumcodereview.appspot.com/12018024/diff/17001/device/bluetooth/b...
File device/bluetooth/bluetooth_adapter_factory.cc (right):

https://chromiumcodereview.appspot.com/12018024/diff/17001/device/bluetooth/b...
device/bluetooth/bluetooth_adapter_factory.cc:33:
std::vector<BluetoothAdapterFactory::AdapterCallback> adapter_callbacks;
Post-commit note:

This violates the style guide which prohibits global variables of class type. 
It also broke the Linux "sizes" test because it introduced a static initializer
to a file that previously had none.