Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 12018002: Adjust test ordering in fullscreen_controller_state_ tests. (Closed)

Created:
7 years, 11 months ago by scheib
Modified:
7 years, 11 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, scheib+watch_chromium.org
Visibility:
Public.

Description

Adjust test ordering in fullscreen_controller_state_ tests. The exhastive soak tests run first, and individual tests after, allowing developers to easily scroll back to the more specific individual test failures when running interactively. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -39 lines) Patch
M chrome/browser/ui/fullscreen/fullscreen_controller_state_interactive_browsertest.cc View 4 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc View 4 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheib
7 years, 11 months ago (2013-01-17 22:47:32 UTC) #1
yzshen1
LGTM Sorry I somehow missed this review.
7 years, 11 months ago (2013-01-23 06:22:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/12018002/1
7 years, 11 months ago (2013-01-23 16:58:28 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-23 21:16:24 UTC) #4
Message was sent while issue was closed.
Change committed as 178383

Powered by Google App Engine
This is Rietveld 408576698