Issue 12016031: Add 'save details in chrome' checkbox.

Issue 12016031: Add 'save details in chrome' checkbox. (Closed)

Created:
7 years, 11 months ago by Evan Stade

Modified:
7 years, 11 months ago

Reviewers:
Ilya Sherman, sky

CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add 'save details in chrome' checkbox. But only show it when something is actually being edited. Eventually we will also hide it when we're not using autofill, but right now we're always using autofill. BUG=157273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178152

Patch Set 1 #

Patch Set 2 : i18n now #

Total comments: 6

Patch Set 3 : change symbol names #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -3 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc	View	1	4 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_view.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_dialog_views.h	View	1 2	4 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View	1 2	7 chunks	+35 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

LGTM https://codereview.chromium.org/12016031/diff/2001/chrome/browser/ui/views/autofill/autofill_dialog_views.h File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): https://codereview.chromium.org/12016031/diff/2001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode246 chrome/browser/ui/views/autofill/autofill_dialog_views.h:246: bool SomethingIsEditing(); Optional nit: Hmm, I find this ...

7 years, 11 months ago (2013-01-19 10:22:13 UTC) #2

Evan Stade

https://codereview.chromium.org/12016031/diff/2001/chrome/browser/ui/views/autofill/autofill_dialog_views.h File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): https://codereview.chromium.org/12016031/diff/2001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode246 chrome/browser/ui/views/autofill/autofill_dialog_views.h:246: bool SomethingIsEditing(); On 2013/01/19 10:22:14, Ilya Sherman wrote: > ...

7 years, 11 months ago (2013-01-22 20:15:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/12016031/7001

7 years, 11 months ago (2013-01-22 20:18:01 UTC) #5

Message was sent while issue was closed.

Change committed as 178152

Expand Messages | Collapse Messages