Chromium Code Reviews
Help | Chromium Project | Sign in
(943)

Issue 12016007: Add a warning about using a component that isn't referenced (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by John Messerly
Modified:
1 year, 2 months ago
CC:
reviews_dartlang.org, Jacob
Base URL:
https://github.com/dart-lang/web-ui.git@master
Visibility:
Public.

Description

Add a warning about using a component that isn't referenced.
Warning was only being issued for is="", now it is for x- tags too. Also added tests for new and existing warnings.

Committed: https://github.com/dart-lang/web-ui/commit/1e956f5

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -14 lines) Lint Patch
M lib/src/analyzer.dart View 3 chunks +11 lines, -8 lines 0 comments ? errors Download
M test/analyzer_test.dart View 4 chunks +32 lines, -1 line 2 comments ? errors Download
M test/testing.dart View 2 chunks +5 lines, -5 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
John Messerly
1 year, 2 months ago #1
Siggi Cherem (dart-lang)
lgtm https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dart File test/analyzer_test.dart (right): https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dart#newcode19 test/analyzer_test.dart:19: import 'testing.dart' as testing; do we need two ...
1 year, 2 months ago #2
John Messerly
1 year, 2 months ago #3
https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dart
File test/analyzer_test.dart (right):

https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dar...
test/analyzer_test.dart:19: import 'testing.dart' as testing;
On 2013/01/18 02:56:56, Siggi Cherem (dart-lang) wrote:
> do we need two imports to the same file?

Not sure what the original intent was?
I guess we are shadowing "analyzeFiles" etc, so we need a qualified "testing"
import.
I suspect other names are used unqualified.

so yes...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434