Issue 12016007: Add a warning about using a component that isn't referenced

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12016007: Add a warning about using a component that isn't referenced (Closed)

Created:
7 years, 11 months ago by Jennifer Messerly

Modified:
7 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, Jacob

Base URL:
https://github.com/dart-lang/web-ui.git@master

Visibility:
Public.

More Reviews

Description

Add a warning about using a component that isn't referenced. Warning was only being issued for is="", now it is for x- tags too. Also added tests for new and existing warnings. Committed: https://github.com/dart-lang/web-ui/commit/1e956f5

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -14 lines)			Patch
M	lib/src/analyzer.dart	View	3 chunks	+11 lines, -8 lines	0 comments	Download
M	test/analyzer_test.dart	View	4 chunks	+32 lines, -1 line	2 comments	Download
M	test/testing.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dart File test/analyzer_test.dart (right): https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dart#newcode19 test/analyzer_test.dart:19: import 'testing.dart' as testing; do we need two ...

7 years, 11 months ago (2013-01-18 02:56:56 UTC) #2

Jennifer Messerly

7 years, 11 months ago (2013-01-18 02:59:31 UTC) #3

https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dart
File test/analyzer_test.dart (right):

https://chromiumcodereview.appspot.com/12016007/diff/1/test/analyzer_test.dar...
test/analyzer_test.dart:19: import 'testing.dart' as testing;
On 2013/01/18 02:56:56, Siggi Cherem (dart-lang) wrote:
> do we need two imports to the same file?

Not sure what the original intent was?
I guess we are shadowing "analyzeFiles" etc, so we need a qualified "testing"
import.
I suspect other names are used unqualified.

so yes...

Expand Messages | Collapse Messages