[strong] Implement strong property access semantics

[strong] Implement strong property access semantics

Revert "Revert relanded strong property access CL"

Regression issues should be solved. Initial patchset is the original, subsequent patchsets are the fixing modifications.

This reverts commit 4ac7be56568f0ac71e7bf10e8bec33c33893e5b5.

BUG=v8:3956
LOG=N

Committed: https://crrev.com/7281f8015181736703d3663c9c570be537f008c1
Cr-Commit-Position: refs/heads/master@{#29384}

[conradw, 2015-06-22 14:22:41]

Patchset #2 (id:20001) has been deleted

[conradw, 2015-06-22 15:01:32]

Patchset #3 (id:60001) has been deleted

[conradw, 2015-06-22 15:52:39]

Patchset #3 (id:80001) has been deleted

[conradw, 2015-06-22 15:52:56]

Patchset #3 (id:80001) has been deleted

[conradw, 2015-06-22 17:34:25]

conradw@chromium.org changed reviewers:
+ mvstanton@chromium.org, rossberg@chromium.org, verwaest@chromium.org

[conradw, 2015-06-22 17:34:26]

PTAL, regressions should be fixed.

It may be worth waiting until after the branch cut to land this, however.

[mvstanton, 2015-06-24 12:08:58]

I just looked at the deltas beyond the original patch, and say LGTM.

[conradw, 2015-06-26 20:24:45]

On 2015/06/24 12:08:58, mvstanton wrote:
> I just looked at the deltas beyond the original patch, and say LGTM.

I'll hold off from committing this until I get lgtm for Toon again, since I had
to rebase over some more of his changes.

[conradw, 2015-06-30 12:17:20]

ping

[rossberg, 2015-06-30 13:02:55]

LGTM. Toon?

[Toon Verwaest, 2015-06-30 14:20:40]

lgtm with 2 minor comments

https://codereview.chromium.org/1199983002/diff/180001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1199983002/diff/180001/src/ic/ic.cc#newcode2959
src/ic/ic.cc:2959: }  // namespace v8::internal
Remove this change from the CL, it's unnecessary. Afaik the format on the left
was introduced by Erik Corry for a script he relies on to speed up compilation.

https://codereview.chromium.org/1199983002/diff/180001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1199983002/diff/180001/src/objects.cc#newcode497
src/objects.cc:497: return GetPropertyWithAccessor(it, language_mode);
You don't need to thread through a language mode here. You can just pass in
SLOPPY right here. The language mode is ignored by the receiver, since it can
only be an Executable Accessor Info here.

See SetPropertyWithFailedAccessCheck.

[conradw, 2015-06-30 14:35:09]

https://codereview.chromium.org/1199983002/diff/180001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1199983002/diff/180001/src/ic/ic.cc#newcode2959
src/ic/ic.cc:2959: }  // namespace v8::internal
On 2015/06/30 14:20:40, Toon Verwaest wrote:
> Remove this change from the CL, it's unnecessary. Afaik the format on the left
> was introduced by Erik Corry for a script he relies on to speed up
compilation.

oops, this wasn't intentional, I'm not sure how it happened (autoformatter?)

done

https://codereview.chromium.org/1199983002/diff/180001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1199983002/diff/180001/src/objects.cc#newcode497
src/objects.cc:497: return GetPropertyWithAccessor(it, language_mode);
On 2015/06/30 14:20:40, Toon Verwaest wrote:
> You don't need to thread through a language mode here. You can just pass in
> SLOPPY right here. The language mode is ignored by the receiver, since it can
> only be an Executable Accessor Info here.
> 
> See SetPropertyWithFailedAccessCheck.

Done.

[conradw, 2015-06-30 14:46:04]

Patchset #10 (id:240001) has been deleted

[conradw, 2015-06-30 15:09:05]

The CQ bit was checked by conradw@chromium.org

[conradw, 2015-06-30 15:09:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, verwaest@chromium.org, rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1199983002/#ps260001
(title: "add TODOs")

[commit-bot: I haz the power, 2015-06-30 15:09:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1199983002/260001

[commit-bot: I haz the power, 2015-06-30 15:24:35]

Committed patchset #10 (id:260001)

[commit-bot: I haz the power, 2015-06-30 15:24:53]

Patchset 10 (id:??) landed as
https://crrev.com/7281f8015181736703d3663c9c570be537f008c1
Cr-Commit-Position: refs/heads/master@{#29384}