Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5600)

Unified Diff: chrome/browser/extensions/test_blacklist.h

Issue 119963004: Manage all the testing classes for Blacklist in TestBlacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/test_blacklist.h
diff --git a/chrome/browser/extensions/test_blacklist.h b/chrome/browser/extensions/test_blacklist.h
index 45ea6cbe78f1e78c33a59ef5b141fb0ced612fd3..ea10bc47db1f7c041fd8aa6e214cb37cdd494201 100644
--- a/chrome/browser/extensions/test_blacklist.h
+++ b/chrome/browser/extensions/test_blacklist.h
@@ -5,26 +5,91 @@
#ifndef CHROME_BROWSER_EXTENSIONS_TEST_BLACKLIST_H_
#define CHROME_BROWSER_EXTENSIONS_TEST_BLACKLIST_H_
+#include <map>
#include <string>
#include "base/basictypes.h"
#include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/blacklist_state_fetcher.h"
namespace extensions {
+class FakeSafeBrowsingDatabaseManager;
+
+// Replace BlacklistStateFetcher for testing of the Blacklist class.
+class BlacklistStateFetcherMock : public BlacklistStateFetcher {
+ public:
+ BlacklistStateFetcherMock();
+
+ virtual ~BlacklistStateFetcherMock();
+
+ virtual void Request(const std::string& id,
+ const RequestCallback& callback) OVERRIDE;
+
+ void SetState(const std::string& id, BlacklistState state);
+
+ void Clear();
+
+ int request_count() const { return request_count_; }
+
+ private:
+ std::map<std::string, BlacklistState> states_;
+ int request_count_;
+};
+
+
// A wrapper for an extensions::Blacklist that provides functionality for
-// testing.
+// testing. It sets up mocks for SafeBrowsing database and BlacklistFetcher,
+// that are used by blacklist to retrieve respectively the set of blacklisted
+// extensions and their blacklist states.
class TestBlacklist {
public:
+ // Use this if the SafeBrowsing and/or StateFetcher mocks should be created
+ // before initializing the Blacklist.
+ explicit TestBlacklist();
+
explicit TestBlacklist(Blacklist* blacklist);
+ ~TestBlacklist();
+
+ void Attach(Blacklist* blacklist);
+
+ // Only call this if Blacklist is destroyed before TestBlacklist, otherwise
+ // it will be performed from the destructor.
+ void Detach();
+
Blacklist* blacklist() { return blacklist_; }
+ // Set the extension state in SafeBrowsingDatabaseManager and
+ // BlacklistFetcher.
+ void SetBlacklistState(const std::string& extension_id,
+ BlacklistState state,
+ bool notify);
+
BlacklistState GetBlacklistState(const std::string& extension_id);
+ void Clear(bool notify);
+
+ void DisableSafeBrowsing();
+
+ void EnableSafeBrowsing();
+
+ void NotifyUpdate();
+
+ const BlacklistStateFetcherMock* fetcher() { return &state_fetcher_mock_; }
+
private:
Blacklist* blacklist_;
+ // The BlacklistStateFetcher object is normally managed by Blacklist. Because
+ // of this, we need to prevent this object from being deleted with Blacklist.
+ // For this, Detach() should be called before blacklist_ is deleted.
+ BlacklistStateFetcherMock state_fetcher_mock_;
+
+ scoped_refptr<FakeSafeBrowsingDatabaseManager> blacklist_db_;
+
+ Blacklist::ScopedDatabaseManagerForTest scoped_blacklist_db_;
+
DISALLOW_COPY_AND_ASSIGN(TestBlacklist);
};
« no previous file with comments | « chrome/browser/extensions/fake_safe_browsing_database_manager.cc ('k') | chrome/browser/extensions/test_blacklist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698