Manage all the testing classes for Blacklist in TestBlacklist.

chrome/browser/extensions/test_blacklist.cc

Index: chrome/browser/extensions/test_blacklist.cc
diff --git a/chrome/browser/extensions/test_blacklist.cc b/chrome/browser/extensions/test_blacklist.cc
index c14cee1339ae23574c872d29f72ef0a396583f06..01c85c6169d9c8c4697a49c7f0bb98a9b7c78e09 100644
--- a/chrome/browser/extensions/test_blacklist.cc
+++ b/chrome/browser/extensions/test_blacklist.cc
@@ -9,14 +9,13 @@
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
+#include "base/stl_util.h"
 #include "chrome/browser/extensions/blacklist.h"
+#include "chrome/browser/extensions/blacklist_state_fetcher.h"
+#include "chrome/browser/extensions/fake_safe_browsing_database_manager.h"
 
 namespace extensions {
 
-TestBlacklist::TestBlacklist(Blacklist* blacklist)
-    : blacklist_(blacklist) {
-}
-
 namespace {
 
 void Assign(BlacklistState *out, BlacklistState in) {
@@ -25,6 +24,91 @@ void Assign(BlacklistState *out, BlacklistState in) {
 
 }  // namespace
 
+BlacklistStateFetcherMock::BlacklistStateFetcherMock() : request_count_(0) {}
+
+void BlacklistStateFetcherMock::Request(const std::string& id,
+                                        const RequestCallback& callback) {
+  request_count_++;

[not at google - send to devlin, 2013/12/21 00:34:24]

++request_count_ for consistency.

[Oleg Eterevsky, 2014/01/09 13:54:01]

Done.

+
+  BlacklistState result = NOT_BLACKLISTED;
+  if (ContainsKey(states_, id))
+    result = states_[id];
+
+  base::MessageLoopProxy::current()->PostTask(FROM_HERE,
+                                              base::Bind(callback, result));
+}
+
+void BlacklistStateFetcherMock::SetState(const std::string& id,
+                                         BlacklistState state)  {
+  states_[id] = state;
+}
+
+void BlacklistStateFetcherMock::Clear() {
+  states_.clear();
+}
+
+
+TestBlacklist::TestBlacklist()
+    : blacklist_(NULL),
+      blacklist_db_(new FakeSafeBrowsingDatabaseManager(true)),
+      scoped_blacklist_db_(blacklist_db_) {
+}
+
+TestBlacklist::TestBlacklist(Blacklist* blacklist)
+    : blacklist_(NULL),
+      blacklist_db_(new FakeSafeBrowsingDatabaseManager(true)),
+      scoped_blacklist_db_(blacklist_db_) {
+  Attach(blacklist);
+}
+
+TestBlacklist::~TestBlacklist() {
+  Detach();
+}
+
+void TestBlacklist::Attach(Blacklist* blacklist) {
+  if (blacklist_)
+    Detach();
+
+  blacklist_ = blacklist;
+  blacklist_->SetBlacklistStateFetcherForTest(&state_fetcher_mock_);
+}
+
+void TestBlacklist::Detach() {
+  blacklist_->ResetBlacklistStateFetcherForTest();

[not at google - send to devlin, 2013/12/21 00:34:24]

this will leak but making ResetBlacklistStateFetcherForTest return a scoped_ptr
will fix that. however you should use IGNORE_RESULT or IgnoreResult or whatever
the macro is called.

[Oleg Eterevsky, 2014/01/09 13:54:01]

Done.
The comment here
https://code.google.com/p/chromium/codesearch#chromium/src/base/basictypes.h&...
implies that ignore_result is needed only when you want to suppress
WARN_UNUSED_RESULT, otherwise it would be all over the sources.

+}
+
+void TestBlacklist::SetBlacklistState(const std::string& extension_id,
+                                      BlacklistState state,
+                                      bool notify) {
+  state_fetcher_mock_.SetState(extension_id, state);
+
+  switch (state) {
+    case NOT_BLACKLISTED:
+      blacklist_db_->RemoveUnsafe(extension_id);
+      break;
+
+    case BLACKLISTED_MALWARE:
+    case BLACKLISTED_SECURITY_VULNERABILITY:
+    case BLACKLISTED_CWS_POLICY_VIOLATION:
+    case BLACKLISTED_POTENTIALLY_UNWANTED:
+      blacklist_db_->AddUnsafe(extension_id);
+      break;
+
+    default:
+      break;
+  }
+
+  if (notify)
+    blacklist_db_->NotifyUpdate();
+}
+
+void TestBlacklist::Clear(bool notify) {
+  state_fetcher_mock_.Clear();
+  blacklist_db_->ClearUnsafe();
+  if (notify)
+    blacklist_db_->NotifyUpdate();
+}
+
 BlacklistState TestBlacklist::GetBlacklistState(
     const std::string& extension_id) {
   BlacklistState blacklist_state;
@@ -34,4 +118,16 @@ BlacklistState TestBlacklist::GetBlacklistState(
   return blacklist_state;
 }
 
+void TestBlacklist::DisableSafeBrowsing() {
+  blacklist_db_->Disable();
+}
+
+void TestBlacklist::EnableSafeBrowsing() {
+  blacklist_db_->Enable();
+}
+
+void TestBlacklist::NotifyUpdate() {
+  blacklist_db_->NotifyUpdate();
+}
+
 }  // namespace extensions