Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: chrome/browser/extensions/blacklist.h

Issue 119963004: Manage all the testing classes for Blacklist in TestBlacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/blacklist.cc » ('j') | chrome/browser/extensions/test_blacklist.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/blacklist.h
diff --git a/chrome/browser/extensions/blacklist.h b/chrome/browser/extensions/blacklist.h
index e3cfc80be41bc05489d3a6a465e119da6c44827a..5df6d9ec5d6de5ebfb075b5784b4339dd154af19 100644
--- a/chrome/browser/extensions/blacklist.h
+++ b/chrome/browser/extensions/blacklist.h
@@ -93,9 +93,14 @@ class Blacklist : public content::NotificationObserver,
void IsBlacklisted(const std::string& extension_id,
const IsBlacklistedCallback& callback);
- // Used to mock BlacklistStateFetcher in unit tests.
+ // Used to mock BlacklistStateFetcher in unit tests. Blacklist owns the
+ // |fetcher|.
void SetBlacklistStateFetcherForTest(BlacklistStateFetcher* fetcher);
+ // Reset the owned BlacklistStateFetcher to null and return the current
+ // BlacklistStateFetcher.
+ BlacklistStateFetcher* ResetBlacklistStateFetcherForTest();
not at google - send to devlin 2013/12/21 00:34:24 return a scoped_ptr<BlacklistStateFetcher> here.
Oleg Eterevsky 2014/01/09 13:54:01 Done.
Oleg Eterevsky 2014/01/09 17:58:10 It turns out, after the holidays I forgot, that it
+
// Adds/removes an observer to the blacklist.
void AddObserver(Observer* observer);
void RemoveObserver(Observer* observer);
« no previous file with comments | « no previous file | chrome/browser/extensions/blacklist.cc » ('j') | chrome/browser/extensions/test_blacklist.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698