Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1199313002: Instead of guessing, compute center point of Guest View for test. (Closed)

Created:
5 years, 6 months ago by wjmaclean
Modified:
5 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instead of guessing, compute center point of Guest View for test. The CL modifies WebViewFocusTest.TouchFocusesEmbedder to compute the center of the Guest View as the target for the synthetic touch event, instead of just guessing at the coordinate. BUG=503499 Committed: https://crrev.com/f293d2be06ee72ea958b35c83336d0ebbe1bcbf6 Cr-Commit-Position: refs/heads/master@{#335837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +9 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
wjmaclean
lazyboy@ - I'm doing to dry-run to make sure this doesn't upset the CQ bots, ...
5 years, 6 months ago (2015-06-23 22:13:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313002/1
5 years, 6 months ago (2015-06-23 22:14:36 UTC) #4
lazyboy
lgtm
5 years, 6 months ago (2015-06-23 22:27:50 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-23 23:22:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313002/1
5 years, 6 months ago (2015-06-24 00:57:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 01:05:50 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 01:06:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f293d2be06ee72ea958b35c83336d0ebbe1bcbf6
Cr-Commit-Position: refs/heads/master@{#335837}

Powered by Google App Engine
This is Rietveld 408576698