Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3431)

Unified Diff: chrome/browser/thumbnails/thumbnail_service_impl.cc

Issue 11985003: Refactored-out the code of thumbnaling algorithm from thumbnail_tab_helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/thumbnails/thumbnail_service_impl.cc
diff --git a/chrome/browser/thumbnails/thumbnail_service_impl.cc b/chrome/browser/thumbnails/thumbnail_service_impl.cc
index 9db8360740e00326a8885375563f339f8021ec70..16441565801f044344f925d75c80ac501d066f67 100644
--- a/chrome/browser/thumbnails/thumbnail_service_impl.cc
+++ b/chrome/browser/thumbnails/thumbnail_service_impl.cc
@@ -6,6 +6,16 @@
#include "base/memory/ref_counted_memory.h"
#include "chrome/browser/history/history.h"
+#include "chrome/browser/thumbnails/simple_thumbnail_crop.h"
+#include "chrome/browser/thumbnails/thumbnailing_context.h"
+
+namespace {
+
+// The thumbnail size in DIP.
+static const int kThumbnailWidth = 212;
sky 2013/01/17 20:18:36 don't need static here.
motek. 2013/01/18 18:38:41 Done.
+static const int kThumbnailHeight = 132;
+
+}
namespace thumbnails {
@@ -16,14 +26,13 @@ ThumbnailServiceImpl::ThumbnailServiceImpl(Profile* profile)
ThumbnailServiceImpl::~ThumbnailServiceImpl() {
}
-bool ThumbnailServiceImpl::SetPageThumbnail(const GURL& url,
- const gfx::Image& thumbnail,
- const ThumbnailScore& score) {
+bool ThumbnailServiceImpl::SetPageThumbnail(const ThumbnailingContext& context,
+ const gfx::Image& thumbnail) {
scoped_refptr<history::TopSites> local_ptr(top_sites_);
if (local_ptr == NULL)
return false;
- return local_ptr->SetPageThumbnail(url, thumbnail, score);
+ return local_ptr->SetPageThumbnail(context.url, thumbnail, context.score);
}
bool ThumbnailServiceImpl::GetPageThumbnail(
@@ -36,6 +45,11 @@ bool ThumbnailServiceImpl::GetPageThumbnail(
return local_ptr->GetPageThumbnail(url, bytes);
}
+ThumbnailingAlgorithm* ThumbnailServiceImpl::CreateThumbnailingAlgorithm()
+ const {
+ return new SimpleThumbnailCrop(gfx::Size(kThumbnailWidth, kThumbnailHeight));
+}
+
bool ThumbnailServiceImpl::ShouldAcquirePageThumbnail(const GURL& url) {
scoped_refptr<history::TopSites> local_ptr(top_sites_);

Powered by Google App Engine
This is Rietveld 408576698