Issue 119823003: DevTools: Extract JS module declarations from compile_frontend.py into js_modules

Issue 119823003: DevTools: Extract JS module declarations from compile_frontend.py into js_modules (Closed)

Created:
7 years ago by apavlov

Modified:
7 years ago

Reviewers:
eustas, vsevik, aandrey

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Extract JS module declarations from compile_frontend.py into js_modules R=aandrey, eustas, vsevik NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164216

Patch Set 1 #

Patch Set 2 : Fix error message #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : Comments addressed #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+371 lines, -359 lines)			Patch
	M	Source/devtools/scripts/compile_frontend.py	View	1 2 3 4	2 chunks	+12 lines, -359 lines	0 comments	Download
	A	Source/devtools/scripts/frontend_modules.json	View	1 2 3 4	1 chunk	+359 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

https://chromiumcodereview.appspot.com/119823003/diff/60001/Source/devtools/scripts/compile_frontend.py File Source/devtools/scripts/compile_frontend.py (right): https://chromiumcodereview.appspot.com/119823003/diff/60001/Source/devtools/scripts/compile_frontend.py#newcode52 Source/devtools/scripts/compile_frontend.py:52: js_modules_name = "js_modules" frontend_modules.json https://chromiumcodereview.appspot.com/119823003/diff/60001/Source/devtools/scripts/compile_frontend.py#newcode56 Source/devtools/scripts/compile_frontend.py:56: modules = eval(js_modules_file.read()) ...

7 years ago (2013-12-20 08:09:23 UTC) #2

apavlov

7 years ago (2013-12-20 08:18:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/119823003/80001

7 years ago (2013-12-20 08:20:36 UTC) #5

Message was sent while issue was closed.

Change committed as 164216

Expand Messages | Collapse Messages