Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11975045: Add a percentage to each metric in the V8 timeline plot (Closed)

Created:
7 years, 11 months ago by haraken
Modified:
7 years, 11 months ago
Reviewers:
Yang, danno
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Add a percentage to each metric in the V8 timeline plot With the percentage, we can easily figure out how much execution time is spent in what metric. c.f. https://docs.google.com/a/google.com/file/d/0B7GPzKNdEGeQU04ySy1qOWNuLWs/edit BUG= Committed: https://code.google.com/p/v8/source/detail?r=13415

Patch Set 1 #

Patch Set 2 : Applied reviewer's comment #

Patch Set 3 : Used ExcludeRanges() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M tools/plot-timer-events.js View 1 2 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
yang: Could you take a look? A graph result is here: https://docs.google.com/a/google.com/file/d/0B7GPzKNdEGeQU04ySy1qOWNuLWs/edit
7 years, 11 months ago (2013-01-17 13:37:26 UTC) #1
Yang
On 2013/01/17 13:37:26, haraken1 wrote: > yang: Could you take a look? > > A ...
7 years, 11 months ago (2013-01-17 14:42:37 UTC) #2
haraken
> You can now, for each event type, merge all the ranges, exclude the intervals ...
7 years, 11 months ago (2013-01-17 14:52:46 UTC) #3
haraken
As discussed offline, I used ExcludeRanges().
7 years, 11 months ago (2013-01-17 15:09:58 UTC) #4
Yang
7 years, 11 months ago (2013-01-17 15:29:28 UTC) #5
On 2013/01/17 15:09:58, haraken1 wrote:
> As discussed offline, I used ExcludeRanges().

LGTM.

Powered by Google App Engine
This is Rietveld 408576698