Prevent a DCHECK when starting a chromeos=1 build with --stub-cros-settings.

Prevent a DCHECK when starting a chromeos=1 build with --stub-cros-settings.

This happens because an observer of kAppPack was added in crrev.com/172473.

The fix shares all the setting names with DeviceSettingsProvider to avoid similar issues in the future.

BUG=chromium:108928
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177205

[Mattias Nissler (ping if slow), 2013-01-16 14:17:18]

LGTM, but note that there are a number of other settings that
DeviceSettingsProvider knows, but StubSettingsProvider doesn't. Maybe we should
publish the array used by DeviceSettingsProvider and use it for
StubSettingsProvider as well?

[Joao da Silva, 2013-01-16 14:36:34]

PTAL, sharing the setting names is a good idea.

[Mattias Nissler (ping if slow), 2013-01-16 14:48:36]

https://codereview.chromium.org/11975009/diff/5001/chrome/browser/chromeos/se...
File chrome/browser/chromeos/settings/device_settings_provider.h (right):

https://codereview.chromium.org/11975009/diff/5001/chrome/browser/chromeos/se...
chrome/browser/chromeos/settings/device_settings_provider.h:42: static const
char** kKnownSettingsEnd;
thinking about it, can't we just make this

static bool* IsDeviceSetting(const std::string& path)

[Joao da Silva, 2013-01-16 15:10:08]

PTAL

https://codereview.chromium.org/11975009/diff/5001/chrome/browser/chromeos/se...
File chrome/browser/chromeos/settings/device_settings_provider.h (right):

https://codereview.chromium.org/11975009/diff/5001/chrome/browser/chromeos/se...
chrome/browser/chromeos/settings/device_settings_provider.h:42: static const
char** kKnownSettingsEnd;
On 2013/01/16 14:48:36, Mattias Nissler wrote:
> thinking about it, can't we just make this
> 
> static bool* IsDeviceSetting(const std::string& path)

Uh, of course.

*main brain turn on*

Done.

[Mattias Nissler (ping if slow), 2013-01-16 18:06:28]

LGTM

[commit-bot: I haz the power, 2013-01-16 18:20:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/11975009/10001

[commit-bot: I haz the power, 2013-01-16 20:16:45]

Change committed as 177205