Issue 11975003: [ChromeDriver] Add support for attaching multiple DevToolsEventListeners to a DevToolsClient.

Issue 11975003: [ChromeDriver] Add support for attaching multiple DevToolsEventListeners to a DevToolsClient. (Closed)

Created:
7 years, 11 months ago by craigdh

Modified:
7 years, 11 months ago

Reviewers:
kkania, frankf

CC:
chromium-reviews, vsevik, yurys, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[ChromeDriver] Add support for attaching multiple DevToolsEventListeners to a DevToolsClient. This is in preparation for adding a NavigationTracker. BUG=169078 TEST=chromedriver2_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177204

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixed nits #

Patch Set 3 : Added OVERRIDE. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -22 lines)			Patch
M	chrome/test/chromedriver/chrome_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome_impl_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/chromedriver/devtools_client.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/devtools_client_impl.h	View	1 2	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/test/chromedriver/devtools_client_impl.cc	View	1	5 chunks	+16 lines, -7 lines	0 comments	Download
M	chrome/test/chromedriver/devtools_client_impl_unittest.cc	View		10 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kkania

lgtm https://codereview.chromium.org/11975003/diff/1/chrome/test/chromedriver/devtools_client_impl.cc File chrome/test/chromedriver/devtools_client_impl.cc (right): https://codereview.chromium.org/11975003/diff/1/chrome/test/chromedriver/devtools_client_impl.cc#newcode75 chrome/test/chromedriver/devtools_client_impl.cc:75: void DevToolsClientImpl::NotifyEventListeners( i think style guide says follow ...

7 years, 11 months ago (2013-01-16 16:57:32 UTC) #2

craigdh

https://codereview.chromium.org/11975003/diff/1/chrome/test/chromedriver/devtools_client_impl.cc File chrome/test/chromedriver/devtools_client_impl.cc (right): https://codereview.chromium.org/11975003/diff/1/chrome/test/chromedriver/devtools_client_impl.cc#newcode75 chrome/test/chromedriver/devtools_client_impl.cc:75: void DevToolsClientImpl::NotifyEventListeners( On 2013/01/16 16:57:33, kkania wrote: > i ...

7 years, 11 months ago (2013-01-16 17:38:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/11975003/2002

7 years, 11 months ago (2013-01-16 17:49:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/11975003/15001

7 years, 11 months ago (2013-01-16 18:03:35 UTC) #6

Message was sent while issue was closed.

Change committed as 177204

Expand Messages | Collapse Messages