Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 11973028: Fix the xrange calculation of the V8 timeline plot (Closed)

Created:
7 years, 11 months ago by haraken
Modified:
7 years, 11 months ago
Reviewers:
Yang, danno
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fix the xrange calculation of the V8 timeline plot Currently an xrange is calculated by V8.Execution. This would be fine for JavaScript benchmarks in which everything happens inside of V8.Execution. On the other hand, in Chrome profiling, events can happen outside of V8.Execution. To visualize such outside events, we need to calculate an xrange so that the xrange covers all events. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M tools/plot-timer-events.js View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
yang: This is a minor fix to the V8 timeline plot for real-world profiling. Would ...
7 years, 11 months ago (2013-01-17 13:47:01 UTC) #1
Yang
7 years, 11 months ago (2013-01-17 14:44:44 UTC) #2
On 2013/01/17 13:47:01, haraken1 wrote:
> yang: This is a minor fix to the V8 timeline plot for real-world profiling.
> Would you take a look?

This is sort of debatable. I coded it this way intentionally since I was only
interested in the parts where V8 executed code, but I guess this would make more
sense generally, so LGTM.

I'm going to land this for you.

Powered by Google App Engine
This is Rietveld 408576698