AndroidVDA by using Android's MediaCodec API.

media/base/android/media_codec_bridge_unittest.cc

Index: media/base/android/media_codec_bridge_unittest.cc
diff --git a/media/base/android/media_codec_bridge_unittest.cc b/media/base/android/media_codec_bridge_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a5f9331e47e531f10af776b36506287619423f01
--- /dev/null
+++ b/media/base/android/media_codec_bridge_unittest.cc
@@ -0,0 +1,172 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "media/base/android/media_codec_bridge.h"
+#include "testing/gmock/include/gmock/gmock.h"
+
+namespace {
+
+// The first frame of
+// http://www.html5rocks.com/en/tutorials/audio/quick/test.mp3
+unsigned char test_mp3[] = {
+  0xff, 0xfb, 0xd2, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, 0x69, 0x05, 0x00,
+  0x00, 0x00, 0x00, 0x00, 0x0d, 0x20, 0x00, 0x00, 0x00, 0x2a, 0x7e, 0x40,
+  0xc0, 0x19, 0x4a, 0x80, 0x0d, 0x60, 0x48, 0x1b, 0x40, 0xf7, 0xbd, 0xb9,
+  0xd9, 0x40, 0x6f, 0x82, 0x01, 0x8b, 0x17, 0xa0, 0x80, 0xc5, 0x01, 0xad,
+  0x9a, 0xd3, 0x00, 0x12, 0xc0, 0x72, 0x93, 0x67, 0xd0, 0x03, 0x6f, 0xa4,
+  0xc0, 0xc3, 0x23, 0xee, 0x9b, 0xc0, 0xcc, 0x02, 0xa0, 0xa1, 0x30, 0x0c,
+  0x52, 0x2d, 0xfd, 0x6e, 0x08, 0x83, 0x60, 0x40, 0x46, 0x06, 0x4b, 0x20,
+  0x82, 0x82, 0x7f, 0xd4, 0x81, 0xe7, 0x00, 0x64, 0x20, 0x18, 0xec, 0xc2,
+  0x06, 0x57, 0x0f, 0x81, 0x93, 0x0b, 0x00, 0x66, 0xe3, 0xb7, 0xe8, 0x32,
+  0x6e, 0xf0, 0x32, 0xb0, 0x58, 0x0c, 0x7c, 0x3a, 0x03, 0x22, 0x14, 0x80,
+  0xc9, 0x01, 0x80, 0x30, 0x20, 0x14, 0x0c, 0x96, 0x73, 0xfe, 0x9f, 0x6c,
+  0x0c, 0xd2, 0x25, 0x0f, 0xdc, 0x0c, 0x32, 0x43, 0x03, 0x27, 0x87, 0xc0,
+  0xc2, 0xc0, 0x20, 0xfc, 0x42, 0xc5, 0xff, 0xff, 0xd4, 0x80, 0x01, 0x01,
+  0x80, 0xc3, 0x81, 0x01, 0x95, 0x03, 0x28, 0x82, 0xc0, 0xc3, 0x01, 0xa1,
+  0x06, 0x81, 0x87, 0xc2, 0x40, 0x64, 0xc1, 0xf0, 0x12, 0x02, 0xff, 0xf6,
+  0x5b, 0x9f, 0x44, 0xdc, 0xdd, 0x0b, 0x38, 0x59, 0xe0, 0x31, 0x71, 0x60,
+  0x0c, 0xb4, 0x22, 0x03, 0x3b, 0x96, 0x40, 0xc8, 0x63, 0x90, 0x0a, 0x23,
+  0x81, 0x9e, 0x4c, 0x20, 0x65, 0xb3, 0x18, 0x19, 0x6c, 0x42, 0x06, 0x36,
+  0x1d, 0x01, 0x90, 0x87, 0xdf, 0xff, 0xd0, 0x65, 0xa6, 0xea, 0x66, 0xfd,
+  0x40, 0x0c, 0x48, 0x03, 0x1a, 0x09, 0x01, 0x21, 0x98, 0x19, 0x2c, 0x36,
+  0x06, 0x43, 0x21, 0x81, 0x92, 0xca, 0x60, 0x64, 0x70, 0xb8, 0x19, 0x20,
+  0x6c, 0x02, 0x83, 0x80, 0xcb, 0x60, 0x65, 0x32, 0x28, 0x18, 0x64, 0x24,
+  0x06, 0x3a, 0x0c, 0x00, 0xe1, 0x00, 0x18, 0xd0, 0x35, 0xff, 0xff, 0xff,
+  0xe8, 0x32, 0xef, 0xb2, 0x90, 0x65, 0xbb, 0xdd, 0x94, 0x82, 0x0b, 0x4c,
+  0xfa, 0x25, 0xf3, 0x74, 0x13, 0x0f, 0xf8, 0x19, 0x28, 0x84, 0x06, 0x36,
+  0x11, 0x01, 0x20, 0x80, 0x18, 0xb4, 0x52, 0x0e, 0x15, 0x00, 0x30, 0x50,
+  0x0c, 0x84, 0x32, 0x03, 0x11, 0x04, 0x03, 0x48, 0x04, 0x00, 0x00, 0x31,
+  0x21, 0x00, 0x0c, 0x84, 0x18, 0x03, 0x07, 0x85, 0x40, 0xc6, 0xa5, 0x70,
+  0x32, 0xb8, 0x7c, 0x0c, 0x54, 0x04, 0x00, 0xd0, 0x08, 0x59, 0x58, 0x18,
+  0x20, 0x14, 0x06, 0x30, 0x30, 0x01, 0x9b, 0x86, 0x00, 0x6b, 0x54, 0xa8,
+  0x19, 0x8c, 0x2a, 0x06, 0x16, 0x09, 0x01, 0xa0, 0xd0, 0xa0, 0x69, 0x74,
+  0xb8, 0x19, 0xc4, 0x4a, 0xa3, 0xda, 0x9d, 0x1e, 0x4f, 0x05, 0xc0, 0x5b,
+  0x0b, 0x03, 0xc2, 0x76, 0xa3, 0x4f, 0xb9, 0x16, 0xc2, 0x70, 0x41, 0x07,
+  0xa0, 0x84, 0x16, 0x38, 0x4a, 0xc8, 0xaf, 0xee, 0x7f, 0x93, 0xb5, 0x5c,
+  0x39, 0x1e, 0x29, 0xd9, 0x8c, 0x80, 0xb5, 0x80, 0xe6, 0x85, 0xb2, 0x99,
+  0x68, 0x85, 0x46, 0x91, 0x60, 0xdb, 0x06, 0xfa, 0x38, 0x7a, 0xc7, 0xac,
+  0x85, 0xa8, 0xd3, 0xe6, 0x99, 0x3b, 0x66, 0x43, 0x23, 0x1f, 0x84, 0xe1,
+  0x65, 0x5e, 0xbc, 0x84, 0x18, 0x62, 0xe6, 0x42, 0x0b, 0x82, 0xe4, 0xd3,
+  0x42, 0xd2, 0x05, 0x81, 0x4e, 0xe4, 0x9f, 0x8c, 0xc8, 0x7f, 0xa3, 0xe0,
+  0x8d, 0xf1, 0x0f, 0x38, 0xe5, 0x3f, 0xc4, 0x2c, 0x24, 0x65, 0x8d, 0xb9,
+  0x58, 0xac, 0x39, 0x0e, 0x37, 0x99, 0x2e, 0x85, 0xe0, 0xb7, 0x98, 0x41,
+  0x20, 0x38, 0x1b, 0x95, 0x07, 0xfa, 0xa8, 0x9c, 0x21, 0x0f, 0x13, 0x8c,
+  0xa5, 0xc1, 0x76, 0xae, 0x0b, 0xc1, 0x30, 0x27, 0x08, 0xc1, 0xf6, 0x4d,
+  0xce, 0xb4, 0x41, 0x38, 0x1e, 0x82, 0x10, 0x74, 0x45, 0x91, 0x90, 0xff,
+  0x41, 0x8b, 0x62, 0x1a, 0x71, 0xb6, 0x45, 0x63, 0x8c, 0xce, 0xb8, 0x54,
+  0x1b, 0xe8, 0x5d, 0x9e, 0x35, 0x9d, 0x6c, 0xac, 0xe8, 0x83, 0xa1, 0xe9,
+  0x3f, 0x13, 0x74, 0x11, 0x04, 0x10, 0xf1, 0x37, 0x38, 0xc6, 0x00, 0x60,
+  0x27, 0x48, 0x38, 0x85, 0x92, 0x76, 0xb7, 0xf3, 0xa7, 0x1c, 0x4b, 0xf9,
+  0x3b, 0x5a, 0x88, 0xac, 0x60, 0x1b, 0x85, 0x81, 0x16, 0xab, 0x44, 0x17,
+  0x08, 0x2e, 0x0f, 0xd4, 0xe2, 0xde, 0x49, 0xc9, 0xe1, 0xc0, 0xc0, 0xa0,
+  0x7e, 0x73, 0xa1, 0x67, 0xf8, 0xf5, 0x9f, 0xc4, 0x21, 0x50, 0x4f, 0x05,
+  0x2c, 0xfc, 0x5c, 0xaa, 0x85, 0xb0, 0xfa, 0x67, 0x80, 0x7e, 0x0f, 0xfd,
+  0x92, 0x30, 0xd5, 0xa0, 0xd4, 0x05, 0xdd, 0x06, 0x68, 0x1d, 0x6e, 0x4e,
+  0x8b, 0x79, 0xd6, 0xfc, 0xff, 0x2e, 0x6e, 0x7c, 0xba, 0x03, 0x90, 0xd4,
+  0x25, 0x65, 0x8e, 0xe7, 0x3a, 0xd1, 0xd6, 0xdc, 0xf0, 0xbe, 0x12, 0xc4,
+  0x31, 0x08, 0x16, 0x70, 0x31, 0x85, 0x61, 0x38, 0x27, 0x0a, 0x91, 0x5f,
+  0x03, 0x38, 0xeb, 0x37, 0x13, 0x48, 0x41, 0xbe, 0x7f, 0x04, 0x70, 0x62,
+  0x2b, 0x15, 0x91, 0x67, 0x63, 0x4f, 0xad, 0xa7, 0x1d, 0x3f, 0x44, 0x17,
+  0x02, 0x08, 0x0d, 0xf2, 0xfc, 0x03, 0xa0, 0x74, 0x21, 0x8b, 0x07, 0x3a,
+  0x8d, 0x0f, 0x54, 0x58, 0x94, 0x12, 0xc5, 0x62, 0x18, 0xb9, 0x42, 0xf0,
+  0x6c, 0x73, 0xa0, 0x92, 0xad, 0x27, 0x1c, 0x20, 0x0f, 0xc1, 0xca, 0x44,
+  0x87, 0x47, 0xc5, 0x43, 0x23, 0x01, 0xda, 0x23, 0xe2, 0x89, 0x38, 0x9f,
+  0x1f, 0x8d, 0x8c, 0xc6, 0x95, 0xa3, 0x34, 0x21, 0x21, 0x2d, 0x49, 0xea,
+  0x4b, 0x05, 0x85, 0xf5, 0x58, 0x25, 0x13, 0xcd, 0x51, 0x19, 0x1a, 0x88,
+  0xa6, 0x83, 0xd6, 0xd0, 0xbc, 0x25, 0x19, 0x1c, 0x92, 0x12, 0x44, 0x5d,
+  0x1c, 0x04, 0xf1, 0x99, 0xdf, 0x92, 0x8e, 0x09, 0x85, 0xf3, 0x88, 0x82,
+  0x4c, 0x22, 0x17, 0xc5, 0x25, 0x23, 0xed, 0x78, 0xf5, 0x41, 0xd1, 0xe9,
+  0x8a, 0xb3, 0x52, 0xd1, 0x3d, 0x79, 0x81, 0x4d, 0x31, 0x24, 0xf9, 0x38,
+  0x96, 0xbc, 0xf4, 0x8c, 0x25, 0xe9, 0xf2, 0x73, 0x94, 0x85, 0xc2, 0x61,
+  0x6a, 0x34, 0x68, 0x65, 0x78, 0x87, 0xa6, 0x4f
+};
+
+}  // namespace
+
+namespace media {
+
+class MediaCodecBridgeTest : public testing::Test {

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

This fixture adds a bunch of boilerplate but little value.
E.g. if you deleted it, the first test would simply turn into:

TEST(MediaCodecBridgeTest, Initialize) {
  MediaCodecBridge media_codec("audio/vorbis");
}

[dwkang1, 2013/01/28 14:54:30]

Done.

+ public:
+  MediaCodecBridgeTest()
+      : media_codec_(NULL) { }
+
+  virtual ~MediaCodecBridgeTest() {
+  }
+
+  void Initialize(const std::string& type) {
+    media_codec_ = scoped_ptr<MediaCodecBridge>(new MediaCodecBridge(type));
+  }
+
+  scoped_ptr<MediaCodecBridge> media_codec_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MediaCodecBridgeTest);
+};
+
+TEST_F(MediaCodecBridgeTest, Initialize) {
+    Initialize("audio/vorbis");

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

indent here and below should be +2 for test bodies (not +4 as you have it).

[dwkang1, 2013/01/28 14:54:30]

Done.

+}
+
+TEST_F(MediaCodecBridgeTest, DoNormal) {
+    Initialize("audio/mpeg");
+
+    media_codec_->ConfigureAudio(
+        "audio/mpeg", 44100, 2, NULL, 0, NULL, 0, 0, 0, 0);
+    media_codec_->Start();
+
+    ASSERT_GT(media_codec_->GetInputBuffers(), 0);
+    ASSERT_GT(media_codec_->GetOutputBuffers(), 0);
+
+    int input_buf_index;

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

Please declare variables as close to first use as possible (usually at first
assignment).

[dwkang1, 2013/01/28 14:54:30]

Done.

+    int output_buf_index;
+    int offset;
+    int size;
+    int flag = 0;
+    int64 input_pts = 0;
+    int64 output_pts;
+
+    input_buf_index = media_codec_->DequeueInputBuffer(25000);
+    ASSERT_GE(input_buf_index, 0);
+    media_codec_->PutToInputBuffer(
+        input_buf_index, test_mp3, sizeof(test_mp3));
+    media_codec_->QueueInputBuffer(
+        input_buf_index, 0, sizeof(test_mp3), ++input_pts, 0);
+
+    input_buf_index = media_codec_->DequeueInputBuffer(25000);

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

s/25000/0/ here and below.

[dwkang1, 2013/01/28 14:54:30]

Changed to INFINITY.

+    media_codec_->PutToInputBuffer(
+        input_buf_index, test_mp3, sizeof(test_mp3));
+    media_codec_->QueueInputBuffer(
+        input_buf_index, 0, sizeof(test_mp3), ++input_pts, 0);
+
+    input_buf_index = media_codec_->DequeueInputBuffer(25000);
+    media_codec_->QueueInputBuffer(
+        input_buf_index, 0, 0, 0, MediaCodecBridge::BUFFER_FLAG_END_OF_STREAM);
+
+    input_pts = 0;
+    while (!(flag & MediaCodecBridge::BUFFER_FLAG_END_OF_STREAM)) {
+      output_buf_index = media_codec_->DequeueOutputBuffer(
+          25000, &offset, &size, &output_pts, &flag);
+      switch (output_buf_index) {
+        case MediaCodecBridge::INFO_TRY_AGAIN_LATER:

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

If you take my suggestion to remove the arbitrary timeout, you can drop this.

[dwkang1, 2013/01/28 14:54:30]

Actually, this is possible output if we use 0. To fail on this case, I think we
need to use -1(infinity). Please me know if I took your comment  in a wrong way.

+          continue;
+
+        case MediaCodecBridge::INFO_OUTPUT_FORMAT_CHANGED:

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

Shouldn't this FAIL() the test?

[dwkang1, 2013/01/28 14:54:30]

This is a legitimate case also for audio.

+          continue;
+
+        case MediaCodecBridge::INFO_OUTPUT_BUFFERS_CHANGED:

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

Since this is the only expected result, ASSERT it and drop the switch.

[dwkang1, 2013/01/28 14:54:30]

Actually, if the index >= 0, that means a frame is decoded.

+          media_codec_->GetOutputBuffers();
+          continue;
+      }
+      EXPECT_LE(1, size);
+      if (!(flag & 4)) {

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

s/4/BUFFER_FLAG_END_OF_STREAM/

[dwkang1, 2013/01/28 14:54:30]

Done.

+        EXPECT_EQ(++input_pts, output_pts);
+      }
+    }

[Ami GONE FROM CHROMIUM, 2013/01/23 01:32:32]

This test would fail to fail if the decoder simply returned EOS immediately.

[dwkang1, 2013/01/28 14:54:30]

I think the failure is legitimate because we passed two valid frames here. It
should not simply return EOS immediately. Am I missing something?

+}
+
+}  // namespace media