Issue 11973008: Replace special IC builtins and stubs in the map's cache by codestubs.

Issue 11973008: Replace special IC builtins and stubs in the map's cache by codestubs. (Closed)

Created:
7 years, 11 months ago by Toon Verwaest

Modified:
7 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Replace special IC builtins and stubs in the map's cache by codestubs. Committed: https://code.google.com/p/v8/source/detail?r=13453

Patch Set 2 : Addressed comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -225 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	2 chunks	+32 lines, -0 lines	0 comments	Download
M	src/arm/ic-arm.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	src/ast.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/builtins.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/builtins.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/code-stubs.h	View	1	2 chunks	+40 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download
M	src/ic.h	View		9 chunks	+36 lines, -16 lines	0 comments	Download
M	src/ic.cc	View		4 chunks	+48 lines, -43 lines	0 comments	Download
M	src/objects-inl.h	View		3 chunks	+9 lines, -2 lines	0 comments	Download
M	src/stub-cache.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	src/type-info.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/type-info.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	2 chunks	+29 lines, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

PTAL. This CL only supports StringLength. ArrayLength and FunctionPrototype will be handled in subsequent CLs.

7 years, 11 months ago (2013-01-17 17:31:55 UTC) #1

Jakob Kummerow

LGTM with nits. https://chromiumcodereview.appspot.com/11973008/diff/3022/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://chromiumcodereview.appspot.com/11973008/diff/3022/src/arm/code-stubs-arm.cc#newcode4518 src/arm/code-stubs-arm.cc:4518: } else { Please add an ...

7 years, 11 months ago (2013-01-21 14:41:39 UTC) #2

Toon Verwaest

7 years, 11 months ago (2013-01-21 14:51:17 UTC) #3

Addressed comments.

https://chromiumcodereview.appspot.com/11973008/diff/3022/src/arm/code-stubs-...
File src/arm/code-stubs-arm.cc (right):

https://chromiumcodereview.appspot.com/11973008/diff/3022/src/arm/code-stubs-...
src/arm/code-stubs-arm.cc:4518: } else {
On 2013/01/21 14:41:39, Jakob wrote:
> Please add an ASSERT(kind_ == Code::LOAD_IC) for documentation purposes. (Same
> on x64.)

Done.

https://chromiumcodereview.appspot.com/11973008/diff/3022/src/code-stubs.h
File src/code-stubs.h (right):

https://chromiumcodereview.appspot.com/11973008/diff/3022/src/code-stubs.h#ne...
src/code-stubs.h:559: Code::Kind kind_;
On 2013/01/21 14:41:39, Jakob wrote:
> protected data members are frowned upon. Please make the field private and
> define a protected getter instead.

Done.

Expand Messages | Collapse Messages