Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11973004: Add filter fo chromeos dirs in filename_rules.gypi (Closed)

Created:
7 years, 11 months ago by tbarzic
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Add filter for chromeos dirs in filename_rules.gypi (to exclude them when not on chromeos) BUG=None TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177501

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M build/filename_rules.gypi View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tbarzic
Please, take a look (I think it would be better if this change is not ...
7 years, 11 months ago (2013-01-16 05:35:06 UTC) #1
jam
lgtm, thanks
7 years, 11 months ago (2013-01-16 17:58:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/11973004/4001
7 years, 11 months ago (2013-01-17 03:10:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile
7 years, 11 months ago (2013-01-17 03:40:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/11973004/14001
7 years, 11 months ago (2013-01-17 04:38:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/11973004/20002
7 years, 11 months ago (2013-01-17 19:07:03 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-17 21:48:40 UTC) #7
Message was sent while issue was closed. 
Change committed as 177501

Powered by Google App Engine
This is Rietveld 408576698