src/json-stringifier.h - Issue 11971015: Skip stack trace formatting in case the global object is already dead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.h

Issue 11971015: Skip stack trace formatting in case the global object is already dead. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix leaks in the setter. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/json-stringifier.h

diff --git a/src/json-stringifier.h b/src/json-stringifier.h

index cec98443a5c628cb103c56e27aec2db4e35a4fb6..6ad2c2bdd1d0eb921082548858d3e6b5374ce65f 100644

--- a/src/json-stringifier.h

+++ b/src/json-stringifier.h

@@ -560,7 +560,7 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSObject(

} else {

bool has_exception = false;

Handle<FixedArray> contents =

- GetKeysInFixedArrayFor(object, LOCAL_ONLY, &has_exception);

+ GetKeysInFixedArrayFor<true>(object, LOCAL_ONLY, &has_exception);

if (has_exception) return EXCEPTION;

for (int i = 0; i < contents->length(); i++) {

« no previous file with comments | « src/isolate.cc ('k') | src/messages.js » ('j') | no next file with comments »