 Chromium Code Reviews
 Chromium Code Reviews Issue 11970009:
  Make the Isolate parameter mandatory in Locker and Unlocker classes.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 11970009:
  Make the Isolate parameter mandatory in Locker and Unlocker classes.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/isolate.h | 
| diff --git a/src/isolate.h b/src/isolate.h | 
| index 8d0575c52d7909063209ed24b37692954092200a..36c0ffa46acbd221040fbaad129806f08c124ad0 100644 | 
| --- a/src/isolate.h | 
| +++ b/src/isolate.h | 
| @@ -1070,6 +1070,10 @@ class Isolate { | 
| return &optimizing_compiler_thread_; | 
| } | 
| + // PreInits and returns a default isolate. Needed when a new thread tries | 
| + // to create a Locker for the first time (the lock itself is in the isolate). | 
| 
Michael Starzinger
2013/01/17 10:53:18
I guess in the long run this method should disappe
 
Sven Panne
2013/01/18 07:20:04
Done.
 | 
| + static v8::Isolate* GetDefaultIsolateForLocking(); | 
| + | 
| private: | 
| Isolate(); | 
| @@ -1153,10 +1157,6 @@ class Isolate { | 
| // If one does not yet exist, allocate a new one. | 
| PerIsolateThreadData* FindOrAllocatePerThreadDataForThisThread(); | 
| - // PreInits and returns a default isolate. Needed when a new thread tries | 
| - // to create a Locker for the first time (the lock itself is in the isolate). | 
| - static Isolate* GetDefaultIsolateForLocking(); | 
| - | 
| // Initializes the current thread to run this Isolate. | 
| // Not thread-safe. Multiple threads should not Enter/Exit the same isolate | 
| // at the same time, this should be prevented using external locking. |