Issue 11969051: Handle the 'cancel' case on attach a file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11969051: Handle the 'cancel' case on attach a file. (Closed)

Created:
7 years, 11 months ago by rkc

Modified:
7 years, 11 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle the 'cancel' case on attach a file. If the user selects a file, then selects a file again and hits cancel, we should handle it correctly and clear the attached file. Currently this tries to read the empty file and causes a JS exception. R=csilv@chromium.org BUG=167821 TEST=Open feedback page, attach a file, attach a file again but cancel. Verify the report can still be sent and the originally attached file is not sent with it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177644