Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 11969014: Don't fail when the flakiness dashboard uploader can't be imported. (Closed)

Created:
7 years, 11 months ago by Peter Beverloo
Modified:
7 years, 11 months ago
Reviewers:
bulach, frankf
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

The flakiness dashboard uploader should be importable from WebKit checkouts. Right now there's an assumption that WebKit lives in src/third_party/, but this is not the case when run_tests.py is ran from a WebKit checkout. BUG=170362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177189

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M build/android/pylib/utils/flakiness_dashboard_results_uploader.py View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Beverloo
Please take a look. I'm not sure if the pylint comment works like this -- ...
7 years, 11 months ago (2013-01-16 16:00:22 UTC) #1
bulach
lgtm, feel free to unbreak webkit and follow up later if frank have any comments. ...
7 years, 11 months ago (2013-01-16 16:29:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/11969014/3001
7 years, 11 months ago (2013-01-16 16:50:16 UTC) #3
frankf
It's not pretty but lgtm.
7 years, 11 months ago (2013-01-16 17:40:02 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 19:00:44 UTC) #5
Message was sent while issue was closed.
Change committed as 177189

Powered by Google App Engine
This is Rietveld 408576698