Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 11969008: Re-enable URLRequest tests disabled due to TestServer flake (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
===================================================================
--- net/url_request/url_request_unittest.cc (revision 177067)
+++ net/url_request/url_request_unittest.cc (working copy)
@@ -1368,7 +1368,7 @@
FilePath()) {}
};
-TEST_F(URLRequestTest, DISABLED_DelayedCookieCallback) {
+TEST_F(URLRequestTest, DelayedCookieCallback) {
LocalHttpTestServer test_server;
ASSERT_TRUE(test_server.Start());
@@ -1408,8 +1408,7 @@
}
}
-// crbug.com/170247
-TEST_F(URLRequestTest, DISABLED_DoNotSendCookies) {
+TEST_F(URLRequestTest, DoNotSendCookies) {
LocalHttpTestServer test_server;
ASSERT_TRUE(test_server.Start());
@@ -2053,8 +2052,7 @@
// issuing a CONNECT request with the magic host name "www.redirect.com".
// The HTTPTestServer will return a 302 response, which we should not
// follow.
-// flaky: crbug.com/96594
-TEST_F(URLRequestTestHTTP, DISABLED_ProxyTunnelRedirectTest) {
+TEST_F(URLRequestTestHTTP, ProxyTunnelRedirectTest) {
ASSERT_TRUE(test_server_.Start());
TestNetworkDelegate network_delegate; // Must outlive URLRequest.
@@ -4851,7 +4849,7 @@
};
// Make sure an FTP request using an unsafe ports fails.
-TEST_F(URLRequestTestFTP, DISABLED_UnsafePort) {
+TEST_F(URLRequestTestFTP, UnsafePort) {
ASSERT_TRUE(test_server_.Start());
URLRequestJobFactoryImpl job_factory;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698