Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 11969008: Re-enable URLRequest tests disabled due to TestServer flake (Closed)

Created:
7 years, 11 months ago by mmenke
Modified:
7 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Re-enable URLRequest tests disabled due to TestServer not starting. This is a random subset of tests that use the TestServer, and we don't want to disable them all, one-by-one, due to this issue. BUG=96594, 151810, 151811, 170247 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177258

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M net/url_request/url_request_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mmenke
Two of the re-enabled tests have no comment about why they were disabled, but the ...
7 years, 11 months ago (2013-01-16 15:47:28 UTC) #1
Paweł Hajdan Jr.
LGTM
7 years, 11 months ago (2013-01-16 18:39:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/11969008/5002
7 years, 11 months ago (2013-01-16 18:52:21 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 23:24:11 UTC) #4
Message was sent while issue was closed.
Change committed as 177258

Powered by Google App Engine
This is Rietveld 408576698