Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 11969006: cros: Trigger immersive mode with F4 maximize key (Closed)

Created:
7 years, 11 months ago by James Cook
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

cros: Trigger immersive mode with F4 maximize key This is a UI experiment that may be reverted for M26 depending on feedback. * Ensure ImmersiveModeController always watches for window property changes. * Trigger immersive mode in ChromeShellDelegate (this is only triggered by F4) * Ensure we hide the immersive mode button when window isn't maximized (there are ordering issues with the window observers for show state that exit immersive mode vs. hide the button) BUG=170167 TEST=added to browser_tests ImmersiveModeController.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177194

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -15 lines) Patch
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +11 lines, -4 lines 1 comment Download
M chrome/browser/ui/views/immersive_mode_controller.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/immersive_mode_controller_browsertest.cc View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
Sky, PTAL. kuscher@ requested this change to push users into immersive mode a bit more ...
7 years, 11 months ago (2013-01-16 01:00:26 UTC) #1
sky
LGTM
7 years, 11 months ago (2013-01-16 15:05:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/11969006/1
7 years, 11 months ago (2013-01-16 16:55:29 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 19:33:50 UTC) #4
Message was sent while issue was closed.
Change committed as 177194

Powered by Google App Engine
This is Rietveld 408576698