[Autofill] Fix up AutofillAgent a bit.

[Autofill] Fix up AutofillAgent a bit.

* Remove an obsolete code path (Blink side is in a separate patch).
* Re-wrap some IPC handler lines to 80-col

BUG=330077
TEST=none
R=estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242054

[Dan Beam, 2013-12-20 03:52:33]

https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/c...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/c...
components/autofill/content/renderer/autofill_agent.cc:451: if
(!element_.isNull()) {
why'd you remove the && node == element_ ?

[Ilya Sherman, 2013-12-20 03:54:37]

https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/c...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/c...
components/autofill/content/renderer/autofill_agent.cc:451: if
(!element_.isNull()) {
On 2013/12/20 03:52:34, Dan Beam wrote:
> why'd you remove the && node == element_ ?

Because |node| doesn't exist anymore, or rather is now always identical to
element_.  Previously, didClearAutofillSelection() could be called from Blink
with no particular guarantees on what the node was, so we had to check... but
that code path doesn't exist anymore.

[Dan Beam, 2013-12-20 03:55:12]

lgtm

https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/c...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/c...
components/autofill/content/renderer/autofill_agent.cc:451: if
(!element_.isNull()) {
On 2013/12/20 03:54:37, Ilya Sherman wrote:
> On 2013/12/20 03:52:34, Dan Beam wrote:
> > why'd you remove the && node == element_ ?
> 
> Because |node| doesn't exist anymore, or rather is now always identical to
> element_.  Previously, didClearAutofillSelection() could be called from Blink
> with no particular guarantees on what the node was, so we had to check... but
> that code path doesn't exist anymore.

oh, duh, sorry

[Evan Stade, 2013-12-20 03:57:01]

lgtm

[commit-bot: I haz the power, 2013-12-20 07:23:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/119683003/1

[commit-bot: I haz the power, 2013-12-20 09:47:27]

Change committed as 242054