Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 119683003: [Autofill] Fix up AutofillAgent a bit. (Closed)

Created:
7 years ago by Ilya Sherman
Modified:
7 years ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Autofill] Fix up AutofillAgent a bit. * Remove an obsolete code path (Blink side is in a separate patch). * Re-wrap some IPC handler lines to 80-col BUG=330077 TEST=none R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242054

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 3 chunks +17 lines, -25 lines 3 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
7 years ago (2013-12-20 02:17:50 UTC) #1
Dan Beam
https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/content/renderer/autofill_agent.cc#newcode451 components/autofill/content/renderer/autofill_agent.cc:451: if (!element_.isNull()) { why'd you remove the && node ...
7 years ago (2013-12-20 03:52:33 UTC) #2
Ilya Sherman
https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/content/renderer/autofill_agent.cc#newcode451 components/autofill/content/renderer/autofill_agent.cc:451: if (!element_.isNull()) { On 2013/12/20 03:52:34, Dan Beam wrote: ...
7 years ago (2013-12-20 03:54:37 UTC) #3
Dan Beam
lgtm https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/content/renderer/autofill_agent.cc File components/autofill/content/renderer/autofill_agent.cc (right): https://chromiumcodereview.appspot.com/119683003/diff/1/components/autofill/content/renderer/autofill_agent.cc#newcode451 components/autofill/content/renderer/autofill_agent.cc:451: if (!element_.isNull()) { On 2013/12/20 03:54:37, Ilya Sherman ...
7 years ago (2013-12-20 03:55:12 UTC) #4
Evan Stade
lgtm
7 years ago (2013-12-20 03:57:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/119683003/1
7 years ago (2013-12-20 07:23:09 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-20 09:47:27 UTC) #7
Message was sent while issue was closed.
Change committed as 242054

Powered by Google App Engine
This is Rietveld 408576698