Issue 11968053: Sort GritSourceFiles() output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Issue 11968053: Sort GritSourceFiles() output. (Closed)

Created:
7 years, 11 months ago by Jói

Modified:
7 years, 11 months ago

Reviewers:

CC:
grit-developer_googlegroups.com

Base URL:
https://grit-i18n.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Sort GritSourceFiles() output. os.walk() is not guaranteed to return output in any particular order, so Help gyp-generated build files be consistent by sorting the list of grit source files used for dependencies, the same way the input file list is already sorted. BUG= Landing this patch from torne@, originally issue 11946054. Committed: https://code.google.com/p/grit-i18n/source/detail?r=102

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	grit_info.py	View		1 chunk	+1 line, -1 line	0 comments	Download