Show dictionary changes in chrome://settings/editDictionary as changes come in

Show dictionary changes in chrome://settings/editDictionary as changes come in

This CL enables showing changes to the custom spelling dictionary in
chrome://settings/editDictionary as the changes come in. Previously, the user
had to refresh the settings page to see changes that did not originate from the
settings page.

BUG=51636
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177860

[please use gerrit instead, 2013-01-17 21:19:54]

Jhawkins: PTAL.

This is a standalone part of https://codereview.chromium.org/11445002/ that
applies to WebUI. I've addressed your comments from 11445002 here.

[James Hawkins, 2013-01-18 21:07:46]

LGTM with nits.

https://codereview.chromium.org/11968050/diff/6/chrome/browser/resources/opti...
File chrome/browser/resources/options/language_dictionary_overlay_word_list.js
(right):

https://codereview.chromium.org/11968050/diff/6/chrome/browser/resources/opti...
chrome/browser/resources/options/language_dictionary_overlay_word_list.js:101: *
The list of words that have been removed from the dictionary, but we have
nit: Avoid pronouns in comments, since pronouns are ambiguous.  Rephrasing to
remove the pronoun almost always produces a more readable comment.

https://codereview.chromium.org/11968050/diff/6/chrome/browser/resources/opti...
chrome/browser/resources/options/language_dictionary_overlay_word_list.js:153:
for (var i = 0; i < entries.length; ++i) {
i++ here and elsewhere.

https://codereview.chromium.org/11968050/diff/6/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/edit_dictionary_browsertest.js (right):

https://codereview.chromium.org/11968050/diff/6/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/edit_dictionary_browsertest.js:77:
TEST_F('EditDictionaryWebUITest', 'testAddNotification', function() {
nit: Document specifically what each test is testing.

[please use gerrit instead, 2013-01-18 23:34:53]

Addressed the comments. Checking in.

https://codereview.chromium.org/11968050/diff/6/chrome/browser/resources/opti...
File chrome/browser/resources/options/language_dictionary_overlay_word_list.js
(right):

https://codereview.chromium.org/11968050/diff/6/chrome/browser/resources/opti...
chrome/browser/resources/options/language_dictionary_overlay_word_list.js:101: *
The list of words that have been removed from the dictionary, but we have
On 2013/01/18 21:07:46, James Hawkins wrote:
> nit: Avoid pronouns in comments, since pronouns are ambiguous.  Rephrasing to
> remove the pronoun almost always produces a more readable comment.

Done.

https://codereview.chromium.org/11968050/diff/6/chrome/browser/resources/opti...
chrome/browser/resources/options/language_dictionary_overlay_word_list.js:153:
for (var i = 0; i < entries.length; ++i) {
On 2013/01/18 21:07:46, James Hawkins wrote:
> i++ here and elsewhere.

Done.

https://codereview.chromium.org/11968050/diff/6/chrome/browser/ui/webui/optio...
File chrome/browser/ui/webui/options/edit_dictionary_browsertest.js (right):

https://codereview.chromium.org/11968050/diff/6/chrome/browser/ui/webui/optio...
chrome/browser/ui/webui/options/edit_dictionary_browsertest.js:77:
TEST_F('EditDictionaryWebUITest', 'testAddNotification', function() {
On 2013/01/18 21:07:46, James Hawkins wrote:
> nit: Document specifically what each test is testing.

Done.

[commit-bot: I haz the power, 2013-01-18 23:38:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/11968050/16002

[commit-bot: I haz the power, 2013-01-18 23:58:36]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-19 21:00:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/11968050/16002

[commit-bot: I haz the power, 2013-01-20 01:09:40]

Change committed as 177860