Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Side by Side Diff: build/common.gypi

Issue 11968049: Set test_isolation_outdir to '' by default (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 # Whether tests targets should be run, archived or just have the 397 # Whether tests targets should be run, archived or just have the
398 # dependencies verified. All the tests targets have the '_run' suffix, 398 # dependencies verified. All the tests targets have the '_run' suffix,
399 # e.g. base_unittests_run runs the target base_unittests. The test target 399 # e.g. base_unittests_run runs the target base_unittests. The test target
400 # always calls tools/swarm_client/isolate.py. See the script's --help for 400 # always calls tools/swarm_client/isolate.py. See the script's --help for
401 # more information and the valid --mode values. Meant to be overriden with 401 # more information and the valid --mode values. Meant to be overriden with
402 # GYP_DEFINES. 402 # GYP_DEFINES.
403 # TODO(maruel): Converted the default from 'check' to 'noop' so work can 403 # TODO(maruel): Converted the default from 'check' to 'noop' so work can
404 # be done while the builders are being reconfigured to check out test data 404 # be done while the builders are being reconfigured to check out test data
405 # files. 405 # files.
406 'test_isolation_mode%': 'noop', 406 'test_isolation_mode%': 'noop',
407 # It must not be '<(PRODUCT_DIR)' alone, the '/' is necessary otherwise 407 # If no directory is specified then a temporary directory will be used.
408 # gyp will remove duplicate flags, causing isolate.py to be confused. 408 'test_isolation_outdir%': '',
409 'test_isolation_outdir%': '<(PRODUCT_DIR)/isolate',
410 409
411 'sas_dll_path%': '<(DEPTH)/third_party/platformsdk_win7/files/redist/x86', 410 'sas_dll_path%': '<(DEPTH)/third_party/platformsdk_win7/files/redist/x86',
412 'wix_path%': '<(DEPTH)/third_party/wix', 411 'wix_path%': '<(DEPTH)/third_party/wix',
413 412
414 'conditions': [ 413 'conditions': [
415 # TODO(epoger): Figure out how to set use_skia=1 for Mac outside of 414 # TODO(epoger): Figure out how to set use_skia=1 for Mac outside of
416 # the 'conditions' clause. Initial attempts resulted in chromium and 415 # the 'conditions' clause. Initial attempts resulted in chromium and
417 # webkit disagreeing on its setting. 416 # webkit disagreeing on its setting.
418 ['OS=="mac"', { 417 ['OS=="mac"', {
419 'use_skia%': 1, 418 'use_skia%': 1,
(...skipping 3565 matching lines...) Expand 10 before | Expand all | Expand 10 after
3985 # settings in target dicts. SYMROOT is a special case, because many other 3984 # settings in target dicts. SYMROOT is a special case, because many other
3986 # Xcode variables depend on it, including variables such as 3985 # Xcode variables depend on it, including variables such as
3987 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3986 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3988 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3987 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3989 # files to appear (when present) in the UI as actual files and not red 3988 # files to appear (when present) in the UI as actual files and not red
3990 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3989 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3991 # and therefore SYMROOT, needs to be set at the project level. 3990 # and therefore SYMROOT, needs to be set at the project level.
3992 'SYMROOT': '<(DEPTH)/xcodebuild', 3991 'SYMROOT': '<(DEPTH)/xcodebuild',
3993 }, 3992 },
3994 } 3993 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698