Move 'theme' parsing out of Extension class

chrome/common/extensions/theme_handler.h

Index: chrome/common/extensions/theme_handler.h
diff --git a/chrome/common/extensions/theme_handler.h b/chrome/common/extensions/theme_handler.h
new file mode 100644
index 0000000000000000000000000000000000000000..fa11885e19b6f93b389f166fabded477cf50b055
--- /dev/null
+++ b/chrome/common/extensions/theme_handler.h
@@ -0,0 +1,55 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_COMMON_EXTENSIONS_THEME_HANDLER_H_

[Yoyo Zhou, 2013/01/26 00:54:02]

I've been thinking about where to put this, since themes are not extensions.
Ideally, there would be a type that encompasses extensions and themes, i.e.
things with manifests, and manifest handling would be associated with that type
rather than Extension. But for now, that type can't be distinguished from
Extension. So can you put this in chrome/common/extensions/api/themes?

[Joe Thomas, 2013/01/26 02:05:55]

Done.

+#define CHROME_COMMON_EXTENSIONS_THEME_HANDLER_H_
+
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest_handler.h"
+
+namespace base {
+class DictionaryValue;
+}
+
+namespace extensions {
+
+// A structure to hold the parsed theme data.
+struct ThemeInfo : public Extension::ManifestData {
+  // Define out of line constructor/destructor to please Clang.
+  ThemeInfo();
+  virtual ~ThemeInfo();
+
+  static base::DictionaryValue* GetThemeImages(const Extension* extension);
+  static base::DictionaryValue* GetThemeColors(const Extension* extension);
+  static base::DictionaryValue* GetThemeTints(const Extension* extension);
+  static base::DictionaryValue* GetThemeDisplayProperties(
+      const Extension* extension);
+
+  // A map of resource id's to relative file paths.
+  scoped_ptr<base::DictionaryValue> theme_images_;
+
+  // A map of color names to colors.
+  scoped_ptr<base::DictionaryValue> theme_colors_;
+
+  // A map of color names to colors.
+  scoped_ptr<base::DictionaryValue> theme_tints_;
+
+  // A map of display properties.
+  scoped_ptr<base::DictionaryValue> theme_display_properties_;
+};
+
+// Parses the "theme" manifest key.
+class ThemeHandler : public ManifestHandler {
+ public:
+  ThemeHandler();
+  virtual ~ThemeHandler();
+
+  virtual bool Parse(const base::Value* value,
+                     Extension* extension,
+                     string16* error) OVERRIDE;
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_COMMON_EXTENSIONS_THEME_HANDLER_H_