Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: chrome/browser/themes/browser_theme_pack.cc

Issue 11968032: Move 'theme' parsing out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TOT (new ManifestHandler interface) + Android gypi changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/themes/browser_theme_pack.cc
diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc
index 6e732cda1b82ed53e15055affd26202c91764e97..aa3250edb5b2ffb117235a886e992f51fb27a387 100644
--- a/chrome/browser/themes/browser_theme_pack.cc
+++ b/chrome/browser/themes/browser_theme_pack.cc
@@ -15,6 +15,7 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/themes/theme_service.h"
+#include "chrome/common/extensions/api/themes/theme_handler.h"
#include "content/public/browser/browser_thread.h"
#include "grit/theme_resources.h"
#include "grit/ui_resources.h"
@@ -454,15 +455,17 @@ scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromExtension(
scoped_refptr<BrowserThemePack> pack(new BrowserThemePack);
pack->BuildHeader(extension);
- pack->BuildTintsFromJSON(extension->GetThemeTints());
- pack->BuildColorsFromJSON(extension->GetThemeColors());
- pack->BuildDisplayPropertiesFromJSON(extension->GetThemeDisplayProperties());
+ pack->BuildTintsFromJSON(extensions::ThemeInfo::GetThemeTints(extension));
+ pack->BuildColorsFromJSON(extensions::ThemeInfo::GetThemeColors(extension));
+ pack->BuildDisplayPropertiesFromJSON(
+ extensions::ThemeInfo::GetThemeDisplayProperties(extension));
// Builds the images. (Image building is dependent on tints).
FilePathMap file_paths;
- pack->ParseImageNamesFromJSON(extension->GetThemeImages(),
- extension->path(),
- &file_paths);
+ pack->ParseImageNamesFromJSON(
+ extensions::ThemeInfo::GetThemeImages(extension),
+ extension->path(),
+ &file_paths);
pack->BuildSourceImagesArray(file_paths);
if (!pack->LoadRawBitmapsTo(file_paths, &pack->images_on_ui_thread_))
« no previous file with comments | « no previous file | chrome/browser/themes/browser_theme_pack_unittest.cc » ('j') | chrome/browser/themes/theme_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698