Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: chrome/common/extensions/extension_file_util.cc

Issue 11968032: Move 'theme' parsing out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TOT (new ManifestHandler interface) + Android gypi changes Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_file_util.h" 5 #include "chrome/common/extensions/extension_file_util.h"
6 6
7 #include <map> 7 #include <map>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/file_path.h" 10 #include "base/file_path.h"
11 #include "base/file_util.h" 11 #include "base/file_util.h"
12 #include "base/files/scoped_temp_dir.h" 12 #include "base/files/scoped_temp_dir.h"
13 #include "base/json/json_file_value_serializer.h" 13 #include "base/json/json_file_value_serializer.h"
14 #include "base/logging.h" 14 #include "base/logging.h"
15 #include "base/metrics/histogram.h" 15 #include "base/metrics/histogram.h"
16 #include "base/path_service.h" 16 #include "base/path_service.h"
17 #include "base/stringprintf.h" 17 #include "base/stringprintf.h"
18 #include "base/threading/thread_restrictions.h" 18 #include "base/threading/thread_restrictions.h"
19 #include "base/utf_string_conversions.h" 19 #include "base/utf_string_conversions.h"
20 #include "chrome/common/chrome_constants.h" 20 #include "chrome/common/chrome_constants.h"
21 #include "chrome/common/chrome_paths.h" 21 #include "chrome/common/chrome_paths.h"
22 #include "chrome/common/extensions/api/extension_action/action_info.h" 22 #include "chrome/common/extensions/api/extension_action/action_info.h"
23 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h " 23 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h "
24 #include "chrome/common/extensions/api/themes/theme_handler.h"
24 #include "chrome/common/extensions/extension.h" 25 #include "chrome/common/extensions/extension.h"
25 #include "chrome/common/extensions/extension_l10n_util.h" 26 #include "chrome/common/extensions/extension_l10n_util.h"
26 #include "chrome/common/extensions/extension_manifest_constants.h" 27 #include "chrome/common/extensions/extension_manifest_constants.h"
27 #include "chrome/common/extensions/extension_messages.h" 28 #include "chrome/common/extensions/extension_messages.h"
28 #include "chrome/common/extensions/extension_resource.h" 29 #include "chrome/common/extensions/extension_resource.h"
29 #include "chrome/common/extensions/manifest_url_handler.h" 30 #include "chrome/common/extensions/manifest_url_handler.h"
30 #include "chrome/common/extensions/message_bundle.h" 31 #include "chrome/common/extensions/message_bundle.h"
31 #include "grit/generated_resources.h" 32 #include "grit/generated_resources.h"
32 #include "net/base/escape.h" 33 #include "net/base/escape.h"
33 #include "net/base/file_stream.h" 34 #include "net/base/file_stream.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 if (!ValidateFilePath(path)) { 256 if (!ValidateFilePath(path)) {
256 *error = 257 *error =
257 l10n_util::GetStringFUTF8(IDS_EXTENSION_LOAD_ICON_FAILED, 258 l10n_util::GetStringFUTF8(IDS_EXTENSION_LOAD_ICON_FAILED,
258 UTF8ToUTF16(iter->second)); 259 UTF8ToUTF16(iter->second));
259 return false; 260 return false;
260 } 261 }
261 } 262 }
262 263
263 // Theme resource validation. 264 // Theme resource validation.
264 if (extension->is_theme()) { 265 if (extension->is_theme()) {
265 DictionaryValue* images_value = extension->GetThemeImages(); 266 DictionaryValue* images_value =
267 extensions::ThemeInfo::GetThemeImages(extension);
266 if (images_value) { 268 if (images_value) {
267 for (DictionaryValue::Iterator iter(*images_value); !iter.IsAtEnd(); 269 for (DictionaryValue::Iterator iter(*images_value); !iter.IsAtEnd();
268 iter.Advance()) { 270 iter.Advance()) {
269 std::string val; 271 std::string val;
270 if (iter.value().GetAsString(&val)) { 272 if (iter.value().GetAsString(&val)) {
271 FilePath image_path = extension->path().Append( 273 FilePath image_path = extension->path().Append(
272 FilePath::FromUTF8Unsafe(val)); 274 FilePath::FromUTF8Unsafe(val));
273 if (!file_util::PathExists(image_path)) { 275 if (!file_util::PathExists(image_path)) {
274 *error = 276 *error =
275 l10n_util::GetStringFUTF8(IDS_EXTENSION_INVALID_IMAGE_PATH, 277 l10n_util::GetStringFUTF8(IDS_EXTENSION_INVALID_IMAGE_PATH,
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 return FilePath(); 759 return FilePath();
758 } 760 }
759 return temp_path; 761 return temp_path;
760 } 762 }
761 763
762 void DeleteFile(const FilePath& path, bool recursive) { 764 void DeleteFile(const FilePath& path, bool recursive) {
763 file_util::Delete(path, recursive); 765 file_util::Delete(path, recursive);
764 } 766 }
765 767
766 } // namespace extension_file_util 768 } // namespace extension_file_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698