Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10129)

Unified Diff: chrome/renderer/extensions/runtime_custom_bindings.cc

Issue 11968028: Remove connect message from Native Messaging API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/runtime_custom_bindings.cc
diff --git a/chrome/renderer/extensions/runtime_custom_bindings.cc b/chrome/renderer/extensions/runtime_custom_bindings.cc
index 2b3c00ab63b6b7b1b3b5d344da2007d1d4899da5..211ad62ebd65082784a7bfc48976424647670f34 100644
--- a/chrome/renderer/extensions/runtime_custom_bindings.cc
+++ b/chrome/renderer/extensions/runtime_custom_bindings.cc
@@ -66,24 +66,18 @@ v8::Handle<v8::Value> RuntimeCustomBindings::OpenChannelToNativeApp(
return v8::Undefined();
// The Javascript code should validate/fill the arguments.
- CHECK(args.Length() >= 3 &&
+ CHECK(args.Length() >= 2 &&
args[0]->IsString() &&
- args[1]->IsString() &&
- args[2]->IsString() &&
- args[3]->IsString());
+ args[1]->IsString());
std::string extension_id = *v8::String::Utf8Value(args[0]->ToString());
std::string native_app_name = *v8::String::Utf8Value(args[1]->ToString());
- std::string channel_name = *v8::String::Utf8Value(args[2]->ToString());
- std::string connect_message = *v8::String::Utf8Value(args[3]->ToString());
int port_id = -1;
renderview->Send(new ExtensionHostMsg_OpenChannelToNativeApp(
renderview->GetRoutingID(),
extension_id,
native_app_name,
- channel_name,
- connect_message,
&port_id));
return v8::Integer::New(port_id);
}

Powered by Google App Engine
This is Rietveld 408576698