Remove connect message from Native Messaging API

Remove connect message from Native Messaging API

Previously chrome.extension.connectNative() was accepting a second parameter
for the first message send to the host. It was inconsistent with 
chrome.extension.connect() and is not really necessary. Also removed
type field from the native messages.

Also fixed in the test to avoid dependency on external test binary files 
(single_message_request.msg and single_message_response.msg).


BUG=142915
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178171

[Matt Perry, 2013-01-17 19:26:38]

Nice cleanup!

LGTM

https://codereview.chromium.org/11968028/diff/11001/chrome/browser/extensions...
File
chrome/browser/extensions/api/messaging/native_message_process_host_unittest_posix.cc
(right):

https://codereview.chromium.org/11968028/diff/11001/chrome/browser/extensions...
chrome/browser/extensions/api/messaging/native_message_process_host_unittest_posix.cc:161:
file_util::Delete(temp_input_file, false /* non-recursive */);
nit: might be better to use a ScopedTempDir and put everything in there so it's
auto-cleaned up.

[Sergey Ulanov, 2013-01-18 02:50:11]

+brettw for OWNERS stamp in chrome/browser/renderer_host
+jschuh for extension_messages.h

mpcomplete@, PTAL, particularly at my new changes in message_service.cc around
NativeMessageProcessHost creation.

In the latest patch set I removed channel_name parameter as it was useless and
also fixed a bug that was breaking the tests (sendMessage() was ignored when
called immediately after connectNative()). Also simplified channel creation
logic.

https://codereview.chromium.org/11968028/diff/11001/chrome/browser/extensions...
File
chrome/browser/extensions/api/messaging/native_message_process_host_unittest_posix.cc
(right):

https://codereview.chromium.org/11968028/diff/11001/chrome/browser/extensions...
chrome/browser/extensions/api/messaging/native_message_process_host_unittest_posix.cc:161:
file_util::Delete(temp_input_file, false /* non-recursive */);
On 2013/01/17 19:26:38, Matt Perry wrote:
> nit: might be better to use a ScopedTempDir and put everything in there so
it's
> auto-cleaned up.

Done.

[jschuh, 2013-01-18 06:07:49]

ipc security lgtm (removing ipc surface is always good :)

[brettw, 2013-01-18 20:40:47]

renderer_host lgtm

[commit-bot: I haz the power, 2013-01-21 20:51:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11968028/25004

[commit-bot: I haz the power, 2013-01-21 21:34:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-22 20:24:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11968028/43004

[Matt Perry, 2013-01-22 20:26:59]

lgtm

[commit-bot: I haz the power, 2013-01-23 00:21:03]

Change committed as 178171

[jln (very slow on Chromium), 2013-01-23 01:28:13]

https://chromiumcodereview.appspot.com/11968028/diff/43004/chrome/browser/ext...
File chrome/browser/extensions/api/messaging/native_message_process_host.cc
(right):

https://chromiumcodereview.appspot.com/11968028/diff/43004/chrome/browser/ext...
chrome/browser/extensions/api/messaging/native_message_process_host.cc:185:
pickle.WriteBytes(message_meta_data, 8);
Oops ?

That's why sizeof is good ;)