Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 11967021: Remove top controls layer from cc/. (Closed)

Created:
7 years, 11 months ago by Ted C
Modified:
7 years, 11 months ago
Reviewers:
danakj, aruslan, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, David Trainor- moved to gerrit, John Knottenbelt, Jerome, aruslan
Visibility:
Public.

Description

Remove top controls layer from cc/. After danakj@ comment on the CL that added the top controls manager, I looked into layer positioning in the browser compositor to keep it in sync with the top controls UI widgets. This removes the need for the top controls layer and also gets rid of the need to pass an increased clip size to the layer tree host. Now the renderer compositor will make the webkit size and the browser compositor will be in charge of moving it around. BUG=161303 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177250

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove invalid TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M cc/layer_tree_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layer_tree_host.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M cc/top_controls_manager.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/top_controls_manager.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ted C
Yay for deleting just added code. But this thankfully allows us to not mess around ...
7 years, 11 months ago (2013-01-16 18:40:38 UTC) #1
aruslan
https://codereview.chromium.org/11967021/diff/1/cc/top_controls_manager.cc File cc/top_controls_manager.cc (right): https://codereview.chromium.org/11967021/diff/1/cc/top_controls_manager.cc#newcode62 cc/top_controls_manager.cc:62: // TODO(tedchoc): Adjust fixed position layers as well. Do ...
7 years, 11 months ago (2013-01-16 18:42:05 UTC) #2
Ted C
https://codereview.chromium.org/11967021/diff/1/cc/top_controls_manager.cc File cc/top_controls_manager.cc (right): https://codereview.chromium.org/11967021/diff/1/cc/top_controls_manager.cc#newcode62 cc/top_controls_manager.cc:62: // TODO(tedchoc): Adjust fixed position layers as well. On ...
7 years, 11 months ago (2013-01-16 18:45:10 UTC) #3
enne (OOO)
lgtm
7 years, 11 months ago (2013-01-16 18:48:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/11967021/6
7 years, 11 months ago (2013-01-16 18:52:00 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 23:04:31 UTC) #6
Message was sent while issue was closed.
Change committed as 177250

Powered by Google App Engine
This is Rietveld 408576698