Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 11964002: Remove IPC::Channel::set_listener(). (Closed)

Created:
7 years, 11 months ago by viettrungluu
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, sail+watch_chromium.org
Visibility:
Public.

Description

Remove IPC::Channel::set_listener(). It wasn't used anywhere other than in ipc_perftests (which, up till very recently, weren't even compiled) in a non-essential way. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M ipc/ipc_channel.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_perftests.cc View 7 chunks +26 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
7 years, 11 months ago (2013-01-15 23:35:28 UTC) #1
jam
lgtm
7 years, 11 months ago (2013-01-16 18:01:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11964002/1
7 years, 11 months ago (2013-01-16 18:13:43 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 19:33:33 UTC) #4
Message was sent while issue was closed.
Change committed as 177192

Powered by Google App Engine
This is Rietveld 408576698